Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add facets settings routes #36

Merged
merged 1 commit into from
Jun 4, 2020
Merged

Add facets settings routes #36

merged 1 commit into from
Jun 4, 2020

Conversation

curquiza
Copy link
Member

@curquiza curquiza commented Jun 3, 2020 •
edited
Loading

NB: tests do not run yet because the v0.11 is not out.
If you want to run the tests with the last version of MeiliSearch, use cargo in the MeiliSearch repo, and go on my branch.

The tests in local:

$ sh scripts/tests.sh
Setting FDs limit to 1000
Launching tests...
PHPUnit 8.5.4 by Sebastian Bergmann and contributors.

............F..............................F..................... 65 / 87 ( 74%)
......................                                            87 / 87 (100%)

Time: 3.76 seconds, Memory: 8.00 MB

There were 2 failures:

1) Tests\Endpoints\ClientTest::testExceptionIfNoIndexWhenDeleting
Failed asserting that exception of type "MeiliSearch\Exceptions\HTTPRequestException" is thrown.

2) Tests\Endpoints\IndexTest::testExceptionIsThrownIfNoIndexWhenDeleting
Failed asserting that exception of type "MeiliSearch\Exceptions\HTTPRequestException" is thrown.

FAILURES!
Tests: 87, Assertions: 335, Failures: 2.

@curquiza curquiza requested review from bidoubiwa and eskombro June 3, 2020 14:15
@curquiza curquiza changed the base branch from master to bump-meilisearch-v0.11 June 3, 2020 14:15
eskombro
eskombro reviewed Jun 3, 2020
View reviewed changes
Copy link
Member

@eskombro eskombro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code and tests seem perfect.

Two tests are failing , related to this issue in MeiliSearch:
meilisearch/meilisearch#741

When that issue is solved this will be ready to go!

@curquiza curquiza requested a review from eskombro June 4, 2020 07:46
eskombro
eskombro approved these changes Jun 4, 2020
View reviewed changes
Copy link
Member

@eskombro eskombro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@curquiza curquiza merged commit adaa2d9 into bump-meilisearch-v0.11 Jun 4, 2020
@curquiza curquiza deleted the add-facets-settings-routes branch June 4, 2020 09:10
curquiza added a commit that referenced this pull request Jun 15, 2020
@curquiza
Upd package for MeiliSearch v0.11 (#35)
81b67c8 
* Upd version

* Add method to use faceting sub routes (#36)

* Implement faceting in search (#37)

* Change create_index prototype (#39)

* Add test with multiple facetFilters (#38)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eskombro eskombro eskombro approved these changes

@bidoubiwa bidoubiwa Awaiting requested review from bidoubiwa

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@curquiza @eskombro