Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove prettier custom options #1663

Merged
merged 2 commits into from
May 29, 2024
Merged

Remove prettier custom options #1663

merged 2 commits into from
May 29, 2024

Conversation

flevi29
Copy link
Collaborator

@flevi29 flevi29 commented May 26, 2024

Pull Request

Related issue

Fixes #1659

What does this PR do?

  • Removes unnecessary prettier options for reasons described in the linked issue
  • Applies these changes to all files

@flevi29 flevi29 added the enhancement New feature or request label May 26, 2024
@flevi29 flevi29 requested a review from brunoocasali May 26, 2024 06:56
@codecov Codecov
Copy link

codecov bot commented May 26, 2024

Codecov Report

Attention: Patch coverage is 97.89842% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 97.43%. Comparing base (6cd64e9) to head (792860d).

Files Patch % Lines
src/clients/client.ts 88.57% 8 Missing ⚠️
src/http-requests.ts 96.82% 2 Missing ⚠️
src/clients/node-client.ts 85.71% 1 Missing ⚠️
tests/utils/meilisearch-test-utils.ts 96.00% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1663   +/-   ##
=======================================
  Coverage   97.43%   97.43%           
=======================================
  Files          22       22           
  Lines         858      858           
  Branches       93       93           
=======================================
  Hits          836      836           
- Misses         21       22    +1     
+ Partials        1        0    -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@flevi29
Copy link
Collaborator Author

flevi29 commented May 26, 2024

MeiliSearchTimeOutError: timeout of 5000ms this keeps happening after a certain version of meilisearch, some API calls just take a lot longer to finish. In #1656 I changed the timeout for at least some calls to one minute.

@flevi29 flevi29 added the skip-changelog The PR will not appear in the release changelogs label May 27, 2024
@flevi29
Copy link
Collaborator Author

flevi29 commented May 28, 2024

I'm not sure what's going on, the default value for "singleQuotes" is false (https://prettier.io/docs/en/options.html#quotes), yet we get single quotes everywhere. On one of my other projects without a .prettierrc I get double quotes. Maybe it's a bug, either way, should just leave config as empty as possible.

@flevi29
Copy link
Collaborator Author

flevi29 commented May 29, 2024

bors merge

meili-bors bot added a commit that referenced this pull request May 29, 2024
@meili-bors @flevi29
Merge #1663
afe303f 
1663: Remove prettier custom options r=flevi29 a=flevi29

# Pull Request

## Related issue
Fixes #1659

## What does this PR do?
- Removes unnecessary prettier options for reasons described in the linked issue
- Applies these changes to all files


Co-authored-by: F. Levi <[email protected]>
@meili-bors meili-bors
Copy link
Contributor

meili-bors bot commented May 29, 2024

Build failed:

@curquiza
Copy link
Member

bors merge

@meili-bors meili-bors
Copy link
Contributor

meili-bors bot commented May 29, 2024

Build succeeded:

@meili-bors meili-bors bot merged commit 7b2054d into meilisearch:main May 29, 2024
7 checks passed
@flevi29 flevi29 deleted the remove-prettier-custom-options branch May 29, 2024 13:21
@curquiza curquiza mentioned this pull request Jul 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brunoocasali brunoocasali brunoocasali approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request skip-changelog The PR will not appear in the release changelogs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove prettier custom options
3 participants
@flevi29 @curquiza @brunoocasali