Remove prettier custom options #1659
Labels
enhancement
New feature or request
Comments
meili-bors bot
added a commit
that referenced
this issue
May 29, 2024
1663: Remove prettier custom options r=flevi29 a=flevi29 # Pull Request ## Related issue Fixes #1659 ## What does this PR do? - Removes unnecessary prettier options for reasons described in the linked issue - Applies these changes to all files Co-authored-by: F. Levi <[email protected]>
meili-bors bot
added a commit
that referenced
this issue
Oct 2, 2024
1696: Remove `.editorconfig` r=curquiza a=flevi29 # Pull Request ## Why? `.editorconfig` was added on the very first commit of this repository, but since then `prettier` has replaced it. Except it wasn't removed. There's no point in having multiple configurations for formatting. Related #1659, in which I wanted to remove all custom options, but didn't know why things still didn't work as they should, and now I know that `prettier` also takes `.editorconfig` into consideration. ## PR checklist Please check if your PR fulfills the following requirements: - [x] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)? - [x] Have you read the contributing guidelines? - [x] Have you made sure that the title is accurate and descriptive of the changes? Thank you so much for contributing to Meilisearch! Co-authored-by: F. Levi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Prettier is about not having any debates on style, and that's why they're not adopting any more options. The recommended way is to just use the default set of options. Most code bases using prettier, in theory, should do the same, so that code stays as readable between code bases as possible. Only options that are necessary should be applied, and other than the plugin for tsdoc, I don't really see any in this project.
https://prettier.io/docs/en/option-philosophy
The text was updated successfully, but these errors were encountered: