Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable limit and offset according to documentation. #1630

Merged
merged 1 commit into from
Feb 14, 2024

Conversation

reijovosu
Copy link
Contributor

@reijovosu reijovosu commented Feb 10, 2024

Pull Request

Related issue

Fixes #<issue_number>

What does this PR do?

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @reijovosu

thanks for the PR

Can you add tests to ensure both parameters you added work?

@curquiza curquiza added the enhancement New feature or request label Feb 12, 2024
@reijovosu
Copy link
Contributor Author

It already has a test:

test(`${permission} key: Get documents with pagination`, async () => {

Only typescript definition was not set.

Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

Copy link

codecov bot commented Feb 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (874cfe0) 97.52% compared to head (cbf832e) 97.52%.
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1630   +/-   ##
=======================================
  Coverage   97.52%   97.52%           
=======================================
  Files          22       22           
  Lines         850      850           
  Branches      102      100    -2     
=======================================
  Hits          829      829           
- Misses         20       21    +1     
+ Partials        1        0    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

meili-bors bot commented Feb 14, 2024

@meili-bors meili-bors bot merged commit 6d7b99e into meilisearch:main Feb 14, 2024
7 checks passed
meili-bors bot added a commit that referenced this pull request Mar 11, 2024
1633: Update version for the next release (v0.38.0) r=brunoocasali a=meili-bot

_This PR is auto-generated._

The automated script updates the version of meilisearch-js to a new version: "v0.38.0"

Part of the work of #1631 

---

This version introduces features released on Meilisearch v1.7.0 🎉
Check out the changelog of [Meilisearch v1.7.0](https://github.com/meilisearch/meilisearch/releases/tag/v1.7.0) for more information on the changes. 

⚠️ If you want to adopt new features of this release, **update the Meilisearch server** to the according version.

 ## ⚠️ Breaking changes

* Update Node.js versions that are used in tests (#1620) `@flevi29`
* `scoreDetails` feature is not experimental anymore. You can directly use `showRankingScoreDetails` during a search without activating the experimental feature 🎉

## 🚀 Enhancements

* `dimensions` field is available to the OpenAi model (#1631) `@nicolasvienot` 
* Enable limit and offset according to documentation. (#1630) `@reijovosu`




Co-authored-by: meili-bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants