Update Node.js versions that are used in tests

[flevi29]

Pull Request

Related issue

Fixes #1618

What does this PR do?

• Previously tested Node.js versions: 14, 16, 18
• Let's drop 14 and 16 as they're EOL and test for current LTS as well, which is 20

PR checklist

Please check if your PR fulfills the following requirements:

• Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
• Have you read the contributing guidelines?
• Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

[flevi29]

Okay I'm guessing something else needs to be changed, which I don't have access to, going by what tests seem to want to run.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a8b5e4b) 97.52% compared to head (84bf2ca) 97.52%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1620   +/-   ##
=======================================
  Coverage   97.52%   97.52%           
=======================================
  Files          22       22           
  Lines         850      850           
  Branches      109      109           
=======================================
  Hits          829      829           
  Misses         20       20           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[curquiza]

Thanks for the PR @flevi29

can you update the bors file? It's our tool to merge PR based on tests
https://github.com/meilisearch/meilisearch-js/blob/main/bors.toml

Also, I am waiting for the comeback of @brunoocasali (since he's the maintainer) to know if he's ok to drop Node 14 and 16 support

I'm personally not against this drop. I just added the breaking change label on the PR -> I know it's not technically a breaking change, but since we are not stable yet (releases are 0.X.Y and not X.Y.Z) we want to increase the minor, and not the patch, to let our users know about this change. This label will automatically update the minor of the release 😊.

[flevi29]

Okay, no problem.

[flevi29]

I know it's not technically a breaking change, but since we are not stable yet (releases are 0.X.Y and not X.Y.Z) we want to increase the minor, and not the patch, to let our users know about this change. This label will automatically update the minor of the release 😊.

I'll keep that in mind, I thought a breaking change would constitute a major version increase. Did that mistake with @meilisearch/instant-meilisearch, and I see @brunoocasali reverted the version. That will cause some problems with the lockfiles of people who already updated to 1.0.0 .

[curquiza]

Yes, when your library is stable (X.Y.Z), a breaking change involves a MAJOR increase
When your library is not stable, as this one (0.X.Y), a breaking change involved a MINOR increase (because your major is 0). Important changes like dropping support, or the introduction of big new features will increase the minor too, no matter you are stable or not.

You can see here our tool (release-drafter) will upgrade the minor and not the major if we have a breaking change labeled PR
https://github.com/meilisearch/meilisearch-js/blob/main/.github/release-draft-template.yml
The tool only creates a draft of the release, and helps us keep track of it, but does not release anything automatically

In the instant meilisearch repository, we don't use the same tool to manage our release and version, so other errors are possible

[curquiza]

Talking with Bruno right now and he agrees

so let's merge, thank you so much @flevi29 🙏

bors merge

[curquiza]

bors merge

[curquiza]

I got this error with bors, don't know how to manage this

I merge manually