Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add proximity precision settings #1619

Merged
merged 2 commits into from
Jan 9, 2024

Conversation

mdubus
Copy link
Member

@mdubus mdubus commented Jan 4, 2024

Pull Request

What does this PR do?

Introduction of the proximity precision settings:

  • addition of the new functions (add / update / delete)
  • update the readme (addition of the new proximity precision section + addition of missing links)
  • update types
  • addition of new tests
  • update snapshots

⚠️ Note that the snapshot will need to be updated again to accept the new embedders object (will come in a specific PR dedicated to the vector search)

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

@mdubus mdubus added the enhancement New feature or request label Jan 4, 2024
Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Momo!

LGTM

I don't approve because we will need to change the null value by the "byWord" one if I'm correct once it's fixed on the engine side

@mdubus mdubus requested a review from curquiza January 9, 2024 07:59
Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Momo!

@curquiza curquiza merged commit 7b52526 into bump-meilisearch-v1.6.0 Jan 9, 2024
4 of 7 checks passed
@curquiza curquiza deleted the add_proximity_precision_setting branch January 9, 2024 08:36
meili-bors bot added a commit that referenced this pull request Jan 15, 2024
1625: Update version for the next release (v0.37.0) r=brunoocasali a=meili-bot

_This PR is auto-generated._

The automated script updates the version of meilisearch-js to a new version: "v0.37.0"

👇 Changelogs
---

## 🚀 Enhancements

* Add support for the new setting: `proximityPrecision` (#1619) mdubus
```js
client.index('books').getProximityPrecision()
client.index('books').updateProximityPrecision('byAttribute')
client.index('books').resetProximityPrecision()
```
* Update error inheritance to extend `MeiliSearchError` (#1607) amit-ksh

## 🧪 Experimental enhancement - Hybrid and vector search

⚠️ This is about an experimental feature of Meilisearch. Activate the [`vectorStore` experimental feature to use it](https://www.meilisearch.com/docs/reference/api/experimental_features#configure-experimental-features)

* Add support for the `embedders` settings (#1623) mdubus
```js
client.index('books').getEmbedders()
client.index('books').updateEmbedders({ default: { source: 'userProvided', dimensions: 1 }})
client.index('books').resetEmbedders()
```

* Add support for the `hybrid` parameter during search (#1623) mdubus

## ⚙️ Maintenance/misc

* Fix test name in error.test.ts (#1609) amit-ksh
* Update Jest (#1622) flevi29

Thanks again to amit-ksh, flevi29! 🎉


Co-authored-by: meili-bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants