Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update error inheritance to extend MeiliSearchError #1607

Merged
merged 1 commit into from
Dec 11, 2023

Conversation

amit-ksh
Copy link
Contributor

@amit-ksh amit-ksh commented Dec 6, 2023

Pull Request

Related issue

Fixes #1565

What does this PR do?

  • Ensure that the base error class(MeiliSearchError) inherits the standard error.
  • All other error classes inherit the MeiliSearchError.

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

Copy link

codecov bot commented Dec 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (802c3c3) 97.44% compared to head (5028d7e) 97.45%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1607   +/-   ##
=======================================
  Coverage   97.44%   97.45%           
=======================================
  Files          22       22           
  Lines         823      826    +3     
  Branches      109      109           
=======================================
+ Hits          802      805    +3     
  Misses         20       20           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@brunoocasali brunoocasali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your contribution!

bors merge

@brunoocasali brunoocasali added the enhancement New feature or request label Dec 11, 2023
Copy link
Contributor

meili-bors bot commented Dec 11, 2023

Build succeeded:

@meili-bors meili-bors bot merged commit 4aa8ba3 into meilisearch:main Dec 11, 2023
8 checks passed
meili-bors bot added a commit that referenced this pull request Jan 15, 2024
1625: Update version for the next release (v0.37.0) r=brunoocasali a=meili-bot

_This PR is auto-generated._

The automated script updates the version of meilisearch-js to a new version: "v0.37.0"

👇 Changelogs
---

## 🚀 Enhancements

* Add support for the new setting: `proximityPrecision` (#1619) mdubus
```js
client.index('books').getProximityPrecision()
client.index('books').updateProximityPrecision('byAttribute')
client.index('books').resetProximityPrecision()
```
* Update error inheritance to extend `MeiliSearchError` (#1607) amit-ksh

## 🧪 Experimental enhancement - Hybrid and vector search

⚠️ This is about an experimental feature of Meilisearch. Activate the [`vectorStore` experimental feature to use it](https://www.meilisearch.com/docs/reference/api/experimental_features#configure-experimental-features)

* Add support for the `embedders` settings (#1623) mdubus
```js
client.index('books').getEmbedders()
client.index('books').updateEmbedders({ default: { source: 'userProvided', dimensions: 1 }})
client.index('books').resetEmbedders()
```

* Add support for the `hybrid` parameter during search (#1623) mdubus

## ⚙️ Maintenance/misc

* Fix test name in error.test.ts (#1609) amit-ksh
* Update Jest (#1622) flevi29

Thanks again to amit-ksh, flevi29! 🎉


Co-authored-by: meili-bot <[email protected]>
@amit-ksh amit-ksh deleted the feat/extend-base-error branch June 23, 2024 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ensure the error handling are following the best practice
2 participants