Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v0.29: add new search parameter matchingStrategy #1865

Merged
merged 9 commits into from
Sep 29, 2022
Merged

v0.29: add new search parameter matchingStrategy #1865

merged 9 commits into from
Sep 29, 2022

Conversation

maryamsulemani97
Copy link
Contributor

closes #1840

@maryamsulemani97 maryamsulemani97 added this to the v0.29 milestone Sep 6, 2022
@maryamsulemani97 maryamsulemani97 changed the title V0.29: add new search parameter matchingStrategy v0.29: add new search parameter matchingStrategy Sep 6, 2022
@maryamsulemani97 maryamsulemani97 changed the base branch from master to v0.29 September 6, 2022 11:05
@maryamsulemani97 maryamsulemani97 marked this pull request as ready for review September 7, 2022 10:55
gmourier
gmourier reviewed Sep 7, 2022
View reviewed changes
Copy link
Member

@gmourier gmourier left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @maryamsulemani97, thanks!

The specification also mentions telemetry changes. Do you manage everything related to the telemetry changes for v0.29 in another PR?

Edit: Yes, I found it. 🧱

guimachiavelli
guimachiavelli requested changes Sep 19, 2022
View reviewed changes
reference/api/search.md Outdated Show resolved Hide resolved
reference/api/search.md Outdated Show resolved Hide resolved
reference/api/search.md Outdated Show resolved Hide resolved
@guimachiavelli
Copy link
Member

Forgot to add this to my review.

I personally prefer using "terms" instead of "words" when talking about the words in a query. It seems a bit safer because a query term might be a number, a code, an acronym, etc (e.g. 1984, 1Q84, TLDR) and because what counts as a word can be tricky in some languages.

dichotommy
dichotommy reviewed Sep 26, 2022
View reviewed changes
Copy link
Contributor

@dichotommy dichotommy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recommended a couple changes since things can always be improved, but this looks good to go to me 👍🏻

reference/api/search.md Outdated Show resolved Hide resolved
reference/api/search.md Outdated Show resolved Hide resolved
.code-samples.meilisearch.yaml Outdated Show resolved Hide resolved
reference/api/search.md Outdated Show resolved Hide resolved
reference/api/search.md Outdated Show resolved Hide resolved
guimachiavelli
guimachiavelli approved these changes Sep 28, 2022
View reviewed changes
Copy link
Member

@guimachiavelli guimachiavelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦝

@maryamsulemani97
Copy link
Contributor Author

bors merge

@bors
Copy link
Contributor

bors bot commented Sep 29, 2022

Build succeeded:

@bors bors bot merged commit 5b137da into v0.29 Sep 29, 2022
@bors bors bot deleted the v0.29--Add-new-search-parameter-matchingStrategy branch September 29, 2022 14:46
@brunoocasali brunoocasali mentioned this pull request Oct 18, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmourier gmourier gmourier approved these changes

@ManyTheFish ManyTheFish ManyTheFish approved these changes

@guimachiavelli guimachiavelli guimachiavelli approved these changes

@dichotommy dichotommy Awaiting requested review from dichotommy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.29
Development

Successfully merging this pull request may close these issues.

v0.29: Add new search parameter matchingStrategy
5 participants
@maryamsulemani97 @guimachiavelli @gmourier @ManyTheFish @dichotommy