Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V0.29: telemetry updates #1862

Merged
merged 2 commits into from
Sep 29, 2022
Merged

V0.29: telemetry updates #1862

merged 2 commits into from
Sep 29, 2022

Conversation

maryamsulemani97
Copy link
Contributor

closes #1836

@maryamsulemani97 maryamsulemani97 added this to the v0.29 milestone Sep 6, 2022
@maryamsulemani97 maryamsulemani97 marked this pull request as ready for review September 8, 2022 10:37
gmourier
gmourier reviewed Sep 9, 2022
View reviewed changes
Copy link
Member

@gmourier gmourier left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @maryamsulemani97

There is also that telemetry changes https://github.com/meilisearch/specifications/pull/174/files#diff-dbac052211a8ea4b2c5d068a6264380740b022efead552b4dfc9e4e8d961f0f4 🤓

@maryamsulemani97
Copy link
Contributor Author

There is also that telemetry changes https://github.com/meilisearch/specifications/pull/174/files#diff-dbac052211a8ea4b2c5d068a6264380740b022efead552b4dfc9e4e8d961f0f4 🤓

@gmourier, wasn't this removed from v0.29?

@gmourier
Copy link
Member

You are right @maryamsulemani97. My bad!

gmourier
gmourier approved these changes Sep 12, 2022
View reviewed changes
Copy link
Member

@gmourier gmourier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

guimachiavelli
guimachiavelli approved these changes Sep 14, 2022
View reviewed changes
Copy link
Member

@guimachiavelli guimachiavelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥜

@guimachiavelli guimachiavelli linked an issue Sep 28, 2022 that may be closed by this pull request
v0.29: Telemetry updates #1836
Closed
@guimachiavelli
Copy link
Member

bors merge

@bors
Copy link
Contributor

bors bot commented Sep 29, 2022

Build succeeded:

@bors bors bot merged commit d82ffc0 into v0.29 Sep 29, 2022
@bors bors bot deleted the v0.29--Telemetry-updates branch September 29, 2022 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmourier gmourier gmourier approved these changes

@guimachiavelli guimachiavelli guimachiavelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.29
Development

Successfully merging this pull request may close these issues.

v0.29: Telemetry updates
3 participants
@maryamsulemani97 @gmourier @guimachiavelli