Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix architecture name in network diagram script #86

Merged
merged 3 commits into from
Jun 13, 2024
Merged

Fix architecture name in network diagram script #86

merged 3 commits into from
Jun 13, 2024

Conversation

ziw-liu
Copy link
Collaborator

@ziw-liu ziw-liu commented Jun 12, 2024

No description provided.

@ziw-liu ziw-liu requested a review from edyoshikun June 12, 2024 18:07
@ziw-liu ziw-liu added the bug Something isn't working label Jun 12, 2024
edyoshikun
edyoshikun approved these changes Jun 12, 2024
View reviewed changes
Copy link
Contributor

@edyoshikun edyoshikun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like the new diagrams. Do you know if these can be rotated? Perhaps this can be used to replace the Readme.md networks.

Works great! Thanks

@ziw-liu
Copy link
Collaborator Author

ziw-liu commented Jun 12, 2024

I really like the new diagrams. Do you know if these can be rotated? Perhaps this can be used to replace the Readme.md networks.

Works great! Thanks

They can be rotated by graph_dir="LR". But they become extremely wide since all the shape text is now in one line.

@ziw-liu ziw-liu merged commit a8bb4fc into main Jun 13, 2024
4 checks passed
@ziw-liu ziw-liu deleted the fix-diagram branch June 13, 2024 00:32
edyoshikun added a commit that referenced this pull request Jun 18, 2024
@ziw-liu @edyoshikun
Fix architecture name in network diagram script (#86)
c56b9d0 
* fix architecture name

* add boxes to the diagram

* deleting some extra redundant lines

---------

Co-authored-by: Eduardo Hirata-Miyasaki <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edyoshikun edyoshikun edyoshikun approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
v0.2.0 release - DL@MBL exercise
Development

Successfully merging this pull request may close these issues.
2 participants
@ziw-liu @edyoshikun