Update:update code and run command

mehdi-fathi · Dec 5, 2023 · ff10f7a · ff10f7a
1 parent d25ba34
commit ff10f7a
Show file tree

Hide file tree

Showing 7 changed files with 32 additions and 14 deletions.
diff --git a/app/Console/Kernel.php b/app/Console/Kernel.php
@@ -15,8 +15,7 @@ protected function schedule(Schedule $schedule): void
     {
         // $schedule->command('inspire')->hourly();
 
-        // $schedule->command(NewsCommand::class)->hourly()
-        //     ->runInBackground()->withoutOverlapping();
+        $schedule->command(NewsCommand::class)->everyMinute()->runInBackground()->withoutOverlapping();
     }
 
     /**

diff --git a/app/Exceptions/Handler.php b/app/Exceptions/Handler.php
@@ -2,7 +2,9 @@
 
 namespace App\Exceptions;
 
+use Illuminate\Database\Eloquent\ModelNotFoundException;
 use Illuminate\Foundation\Exceptions\Handler as ExceptionHandler;
+use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;
 use Throwable;
 
 class Handler extends ExceptionHandler
@@ -27,4 +29,13 @@ public function register(): void
             //
         });
     }
+
+    public function render($request, Throwable $exception)
+    {
+        if ($exception instanceof ModelNotFoundException) {
+            return response()->json(['message' => 'Resource not found'], 404);
+        }
+
+        return parent::render($request, $exception);
+    }
 }
diff --git a/app/Jobs/GuardianNewsAPICollectorJob.php b/app/Jobs/GuardianNewsAPICollectorJob.php
@@ -111,8 +111,6 @@ private function saveNews($results): void
 
             } catch (\PDOException $e) {
 
-                dump("error");
-
                 continue;
             }
         }

diff --git a/app/Jobs/NewsAPICollectorJob.php b/app/Jobs/NewsAPICollectorJob.php
@@ -127,8 +127,6 @@ private function saveNews($articles): void
 
             } catch (\PDOException $e) {
 
-                dump("error: ", $data['title'], $e);
-
                 continue;
             }
         }

diff --git a/app/Logic/Utility/EndPointFetcher.php b/app/Logic/Utility/EndPointFetcher.php
@@ -8,10 +8,9 @@
 interface EndPointFetcher
 {
     /**
-     * @param $base_ur
+     * @param string $base_ur
      */
-    public function __construct($base_ur);
-
+    public function __construct(string $base_ur);
 
     /**
      * @param string $uri

diff --git a/app/Logic/Utility/NewsFetcherUtility.php b/app/Logic/Utility/NewsFetcherUtility.php
@@ -4,11 +4,20 @@
 
 use GuzzleHttp\ClientInterface;
 
+/**
+ *
+ */
 class NewsFetcherUtility implements EndPointFetcher
 {
-    public ClientInterface $client;
+    /**
+     * @var \GuzzleHttp\ClientInterface|\GuzzleHttp\Client
+     */
+    public ClientInterface|\GuzzleHttp\Client $client;
 
-    public function __construct($base_url)
+    /**
+     * @param string $base_url
+     */
+    public function __construct(string $base_url)
     {
         $this->client = new \GuzzleHttp\Client([
             'base_uri' => $base_url, // Replace with the actual base URI
@@ -17,9 +26,14 @@ public function __construct($base_url)
     }
 
 
+    /**
+     * @param string $uri
+     * @param $queryParams
+     * @return mixed
+     * @throws \GuzzleHttp\Exception\GuzzleException
+     */
     public function get(string $uri, $queryParams)
     {
-        dump($queryParams);
         $res = $this->client->request('GET', $uri, ['query' => $queryParams]);
         return json_decode($res->getBody()->getContents(), true);
     }

diff --git a/config/news_endpoints.php b/config/news_endpoints.php
@@ -3,8 +3,7 @@
 
 return [
     'news-api' => [
-
-        'key' => 'cedc49391f90414382ff139b743013c8',
+        'key' => '77ce12864b7548c5be2f474a81790e0b',
         'base_url' => 'https://newsapi.org/v2/',
     ],
-Original file line number
+Diff line change
@@ Expand Up / @@ -111,8 +111,6 @@ private function saveNews($results): void @@
                 } catch (\PDOException $e) {
-                    dump("error");
                     continue;
                 }
             }
@@ Expand Down @@