-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wc 106 redux form toggle #310
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
import React from 'react'; | ||
import TogglePill from '../TogglePill'; | ||
|
||
/** | ||
* @param {Object} props - props passed in from parent and redux-form | ||
* @description wraps standard TogglePill web component for use with redux-form | ||
* deconstructs props that redux-forms sets and sets them on TogglePill | ||
* | ||
* NOTE: redux-form expects checkboxes value to be true/false and will set them as so | ||
* https://github.com/erikras/redux-form/issues/2922, therefore using the value here to | ||
* set isActive | ||
* | ||
* @return {Component} TogglePill | ||
*/ | ||
const ReduxFormTogglePill = props => { | ||
// not adding meta error to TogglePill prop for now | ||
// since TogglePills should function in a group with one error | ||
const { | ||
meta, // eslint-disable-line no-unused-vars | ||
input, | ||
...other | ||
} = props; | ||
|
||
return <TogglePill {...input} isActive={input.value == 'true' && !other.useRadio} {...other} />; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. reading |
||
}; | ||
|
||
ReduxFormTogglePill.displayName = 'ReduxFormTogglePill'; | ||
|
||
export default ReduxFormTogglePill; | ||
|
10 changes: 10 additions & 0 deletions
10
src/forms/redux-form/__snapshots__/togglePill.test.jsx.snap
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
// Jest Snapshot v1, https://goo.gl/fbAQLP | ||
|
||
exports[`redux-form TogglePill renders a TogglePill component with expected attributes from mock data 1`] = ` | ||
<WithToggle | ||
isActive={false} | ||
label="Parenting" | ||
name="parenting" | ||
value={false} | ||
/> | ||
`; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,34 @@ | ||
import React from 'react'; | ||
import { shallow, mount } from 'enzyme'; | ||
import ReduxFormTogglePill from './TogglePill'; | ||
|
||
describe('redux-form TogglePill', function() { | ||
|
||
// props given in the structure that | ||
// redux form would | ||
const togglePillProps = { | ||
input: { | ||
label: 'Parenting', | ||
name: 'parenting', | ||
value: false, // as a checkbox, redux form will pass true / false for values | ||
} | ||
}; | ||
|
||
it('renders a TogglePill component with expected attributes from mock data', () => { | ||
const component = shallow(<ReduxFormTogglePill {...togglePillProps} />); | ||
expect(component).toMatchSnapshot(); | ||
}); | ||
|
||
it('renders a TogglePill with isActive prop as false when value is false', () => { | ||
const component = mount(<ReduxFormTogglePill {...togglePillProps} />); | ||
expect(component.find('TogglePill').prop('isActive')).toBe(false); | ||
}); | ||
|
||
it('renders a TogglePill with isActive prop as true when value is true', () => { | ||
togglePillProps.input.value = true; | ||
const component = mount(<ReduxFormTogglePill {...togglePillProps} />); | ||
expect(component.find('TogglePill').prop('isActive')).toBe(false); | ||
}); | ||
|
||
}); | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍