Wc 106 redux form toggle #310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unjust
commented
Oct 5, 2017
| ...other | ||
| } = props; | ||
|
|
||
| return <TogglePill {...input} isActive={input.value == 'true' && !other.useRadio} {...other} />; |
There was a problem hiding this comment.
reading other.useRadio since I do not know if there are similar idiosyncracies for Redux Form radio values. I think if we come up against the same thing for the radios, we can remove this check.
burrata
approved these changes
Oct 5, 2017
| * @return {Component} TogglePill | ||
| */ | ||
| const ReduxFormTogglePill = props => { | ||
| // not adding meta error to TogglePill prop for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues
Fixes https://meetup.atlassian.net/browse/WC-106
Description
The problem: Redux Form's implementation for checkboxes sets the value as
trueorfalse, unlike expected html behavior that separatesname,value, andchecked.redux-form/redux-form#2922
If we want our TogglePill's to be
checked, we need to read theinput.valueprop from Redux Form (which is true or false), and pass that toisActive.Screenshots (if applicable)