Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nightly link checks #686

Merged
merged 8 commits into from
Apr 28, 2022
Merged

Add nightly link checks #686

merged 8 commits into from
Apr 28, 2022

Conversation

mrjones-plip
Copy link
Contributor

per #366

@@ -1,6 +1,6 @@
#!/bin/bash

# This script is used in Github Actions to do link checking on commits to branches and main, so
# This script is used in Github Actions to do link checking on commits to branches and master, so
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

main, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

d'oh! fixed in 367f835 and 39f0f5d

@mrjones-plip mrjones-plip changed the title Add nighlty link checks Add nightly link checks Apr 27, 2022
@mrjones-plip mrjones-plip marked this pull request as ready for review April 28, 2022 02:43
@mrjones-plip
Copy link
Contributor Author

@garethbowen - big bummer is we can't test it 'til it's in main :shrug:

Scheduled workflows run on the latest commit on the default or base branch.

For initial launch, we'll just post to Slack. First couple of runs will spam the channel, but it should quiet down after we tend to the 404ed links. I thought this was easier than creating a ticket and then checking if the ticket existed and not create dupe etc.

Copy link
Member

@garethbowen garethbowen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work! Go for it.

@mrjones-plip mrjones-plip merged commit a8ea000 into main Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants