-
-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add nightly link checking #366
Comments
This is what I yanked out of # Pinning to current version as of Aug 3, 2020 for stability
- name: All Branches - Install Go v1.14
uses: actions/setup-go@v2
with:
go-version: '1.14'
# Pinning to current version as of Aug 3, 2020 for stability
- name: All Branches - Install Muffet v1.3.3
run: env GO111MODULE="on" go get github.com/raviqqe/[email protected]
# run in background so CI doesn't hang waiting for "ctrl + c". Sleep so hugo server is ready
- name: All Branches - Serve Hugo site
run: |
hugo server&
sleep 5
- name: All Branches - Run Muffet link checker
shell: bash
run: ./.github/scripts/muffet.sh |
When ever this gets tended to, we should likely refactor the filenames so that they're logical. Maybe move |
a helpful not from @nomulex which I agree with:
|
* Add nighlty link checks per #366 * test schedule * comment out schedule for now, switch master -> main * switch master -> main x2 * second schedule test * third schedule test * switch over to real schedule
Now that we've removed per commit link checking on PRs, we should add nightly link checking on the entire repo. This will enable us to catch link rot overtime. In the original link checker effort (see #259), we used
muffet
. This is still a good tool! We should just run them on a schedule with something like:What we have right now runs on every push:
And then we check for if we're on master or not to only run certain parts of the CI workflow:
Check out the resulting PR from #367 as that will show what we need to add back in to the nightly runs.
The text was updated successfully, but these errors were encountered: