-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Add workflow file for pull requests #59
ci: Add workflow file for pull requests #59
Conversation
@abhishek276533 is attempting to deploy a commit to the Measured Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @abhishek276533! Very necessary PR.
Unfortunately the build failed - please see my comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, nearly there now! 👍
Build is failing due to issue with generator step - please see comment.
@chrisvxd I'm facing the same error while running |
@chrisvxd Have you tried running |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working now! Thanks @abhishek276533.
Yes I tested yarn build in the recipe and it worked. It might be my local environment but let's discuss in #48.
Adds ci file which checks lint & formatting along with build for pull requests & direct push
@chrisvxd Let me know if there are any changes you want