Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate templates from recipes #10

Closed
chrisvxd opened this issue Jun 11, 2023 · 0 comments · Fixed by #176
Closed

Generate templates from recipes #10

chrisvxd opened this issue Jun 11, 2023 · 0 comments · Fixed by #176
Assignees
Labels
ready Assumed ready enough to start type: refactor

Comments

@chrisvxd
Copy link
Member

chrisvxd commented Jun 11, 2023

The code in /recipes and /packages/create-puck-app/templates is currently duplicated. We should reconcile these to prevent users from committing changes to the wrong directory. See #120 for example.

Solution

Suggest we should add a script that either:

  1. (Preferred) Generate the template from the recipe, as recipes are the logical entry point for people to make changes.
  2. Generate the recipe from the template

Considerations

  • If going with option 1, preserve the handlebars template files (package.json, anything else)
  • Add a CI check to make sure there is no diff (run the script and check for working changes. None should be present)
@chrisvxd chrisvxd self-assigned this Oct 9, 2023
@chrisvxd chrisvxd added ready Assumed ready enough to start and removed in triage labels Oct 9, 2023
@chrisvxd chrisvxd changed the title Don't duplicate code between generator templates and recipes Generate generator templates from recipes Oct 9, 2023
@chrisvxd chrisvxd changed the title Generate generator templates from recipes Generate templates from recipes Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready Assumed ready enough to start type: refactor
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant