fix: Translate ISO 8601 Datetime Durations During Scraping/Parsing/Migrating #2810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It takes like 18 years for tests to run on my instance but it took 5 minutes to run on GH... |
boc-the-git
reviewed
Feb 8, 2024
boc-the-git
reviewed
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
(REQUIRED)
What this PR does / why we need it:
(REQUIRED)
Adds backend translations to the ISO 8601 time duration parsing
Which issue(s) this PR fixes:
(REQUIRED)
Mostly fixes #2807 (see below)
Special notes for your reviewer:
(fill-in or delete this section)
Most of the PR is properly propagating the localizer down to the scraper/cleaning functions. I also had to implement some logic to properly parse "plural" translations. I'm not sure why we have a manual implementation for i18n parsing on the backend, but I basically followed the Vue docs and mirrored that functionality (and added tests)
Part of #2807 mentions that "serving" isn't translated, but looking at the example website source there is no word (it's just the number "1"). I tried my best to find where the word "serving" gets added, but I can't find it. I think it's somewhere deep in the recipe scrapers library, but I'm not sure. It's not in Mealie (I did a painfully exhaustive search for the word "serving" in the codebase). I thought it might get added in the cleaning process, but it definitely doesn't
Testing
(fill-in or delete this section)
Pytest