Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Truncate UIDs and GIDs larger than 999999 (rev2) #32

Merged
merged 2 commits into from
Mar 27, 2024

Conversation

gregoster
Copy link

Truncate UIDs and GIDs larger than 999999 so they do not overflow the 6-character field. (Second version. Replaces #31 )

@mdsteele
Copy link
Owner

Looks good, thanks. Could you also add a new unit test to the bottom of builder.rs? Something kind of like this one, but setting UID/GID to some values > 999999, with the expected text showing the expected truncation.

@mdsteele
Copy link
Owner

(Also, note that you don't need to open a new pull request to make changes; you can just push more changes to your same branch.)

@gregoster
Copy link
Author

Done! And ya, I'm still figuring out github workflows too :)

@mdsteele mdsteele merged commit 99b8505 into mdsteele:master Mar 27, 2024
4 checks passed
@mdsteele
Copy link
Owner

Thanks!

niklasf added a commit to niklasf/rust-ar that referenced this pull request Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants