Truncate UIDs and GIDs larger than 999999 #31
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… 6-character field.
| @@ -245,8 +245,8 @@ impl Header { | |||
| "#1/{:<13}{:<12}{:<6}{:<6}{:<8o}{:<10}`", | |||
| padded_length, | |||
| self.mtime, | |||
| self.uid, | |||
| self.gid, | |||
| format!("{:.*}",6,self.uid.to_string()), | |||
There was a problem hiding this comment.
Since the length is fixed, you can just do {:.6} instead of .* with the 6 as a parameter. And since the writeln above already does formatting, you don't need a separate format call here. You can just change the {:<6} above to {:<6.6} and only do a self.uid.to_string() here.
Also, you can run cargo fmt to format all files according to the project settings.
There was a problem hiding this comment.
This all sounds so much better :) One moment.
There was a problem hiding this comment.
Thanks for the suggestions. See: #32
|
Can be closed now (#32 landed instead). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Truncate UIDs and GIDs larger than 999999 so they do not overflow the 6-character field.