Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(placement): adjust hover style for links #9981

Merged
merged 9 commits into from
May 2, 2024
Merged

fix(placement): adjust hover style for links #9981

Changes from 7 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
32a7408
fix(placement): underline "Don't want to see ads?" link on hover
caugner Nov 8, 2023
e8b0bbc
fix(placement): add hover state for "Mozilla ads" link
caugner Nov 8, 2023
5ee0a70
Merge branch 'main' into fix-hover-style-of-placement-links
caugner Nov 21, 2023
d92a21a
fix(placement): consolidate .pong-note style
caugner Nov 30, 2023
d98d42e
chore(placement): define active link behavior
caugner Nov 30, 2023
7df8f54
fix(placement): restrict hover behavior to .no-pong
caugner Nov 30, 2023
dba7e7b
chore(placement): generalize .pong-note style
caugner Nov 30, 2023
4bbcc5a
fix(placement): underline "Mozilla ads" only in side/bottom banner
caugner Nov 30, 2023
a2dcb69
Merge branch 'main' into fix-hover-style-of-placement-links
caugner May 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 26 additions & 7 deletions client/src/ui/organisms/placement/index.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,21 @@ section.place {
}
}

.pong-note {
text-decoration: none;

&:active,
&:link,
&:visited {
text-decoration: underline;
caugner marked this conversation as resolved.
Show resolved Hide resolved
}

&:focus,
&:hover {
text-decoration: none;
}
}

.no-pong {
color: var(--text-secondary);
font-size: 0.6rem;
Expand All @@ -55,6 +70,17 @@ section.place {
padding: 0;
text-decoration: underline;
width: 100%;

&:link,
&:visited {
text-decoration: none;
}

&:active,
&:focus,
&:hover {
text-decoration: underline;
}
}

&.side {
Expand Down Expand Up @@ -125,13 +151,6 @@ section.place {
grid-area: note;
margin: 0 0 auto auto;
padding: 0 0.5rem 0.125rem;
text-decoration: none;

&:hover,
&:focus,
&:active {
text-decoration: underline;
}
}
}

Expand Down
Loading