-
Notifications
You must be signed in to change notification settings - Fork 509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(placement): adjust hover style for links #9981
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code lgtm, I'll let you test when you add screenshots 🚀
Noticed two issues:
edit: Fixed now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good, but a super opinionated view (so feel free to ignore) on the "Mozilla ads" underline (I think it looks bad):
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Self-approval, and tested again:
- In the top, both "Mozilla ads" and "Don't want to see ads?" are underlined only on hover.
- In the sidebar, "Mozilla ads" is underlined except on hover, and "Don't want to see ads?" is underlined only on hover.
- In the footer, "Mozilla ads" is underlined except on hover, and "Don't want to see ads?" is underlined only on hover.
Bottom line is this now works as expected, and code changes have already been reviewed by Leo.
Summary
Problem
The "Mozilla ads" and "Don't want to see ads?" are not always recognizable as links, because they don't always change their
text-decoration
on hover.Solution
Make sure that the
text-decoration
changes on hover.Screenshots
Before
Screen.Recording.2023-11-30.at.14.33.11.mov
After
Screen.Recording.2023-11-30.at.14.34.40.mov
How did you test this change?
Ran
yarn dev
withREACT_APP_KUMA_HOST=developer.allizom.org
andREACT_APP_PLACEMENT_ENABLED=true
in my.env
and looked at http://localhost:3000/en-US/docs/Web/HTML, then compared withmain
.