more travis #22
Merged
more travis #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry, I don't really feel qualified to review this. Perhaps @schalkneethling or @escattone might have more useful things to say? |
schalkneethling
approved these changes
Jun 11, 2019
|
Actually, I'm pretty confident this is good enough. It's certainly not perfect but the cost of worrying too much, at this point, is not productive. What terrible mistakes we make here don't have deep repercussions, unlike mistakes we make in the policy of the structured content for example. Let's iterate instead. |
peterbe
added a commit
that referenced
this pull request
May 24, 2021
* price blurb * new URL Co-authored-by: Daryl Alexsy <[email protected]>
escattone
pushed a commit
that referenced
this pull request
May 24, 2021
* added top banner * added layout * updated copy * price blurb (#22) * price blurb * new URL Co-authored-by: Daryl Alexsy <[email protected]> * fixed waitlist routing * font scaling * Upgrade landing page survey (#23) * price blurb * upgrade landing page survey * remove 'Dev Reset survey' button because you just start in a new tab * change API URL and don't bother sending 'variant' as a query string Co-authored-by: Daryl Alexsy <[email protected]> * update to survey questions (#28) * codepen examples (#27) Co-authored-by: Daryl Alexsy <[email protected]> * added deep dive code pens * fixed buttons * styled survey questions * lazy loading on codepen iframes * terms and privacy external links * Revert "terms and privacy external links" This reverts commit e4aa38e. Co-authored-by: Daryl Alexsy <[email protected]> Co-authored-by: Daryl Alexsy <[email protected]>
peterbe
added a commit
to peterbe/yari
that referenced
this pull request
Jun 1, 2021
* added top banner * added layout * updated copy * price blurb (mdn#22) * price blurb * new URL Co-authored-by: Daryl Alexsy <[email protected]> * fixed waitlist routing * font scaling * Upgrade landing page survey (mdn#23) * price blurb * upgrade landing page survey * remove 'Dev Reset survey' button because you just start in a new tab * change API URL and don't bother sending 'variant' as a query string Co-authored-by: Daryl Alexsy <[email protected]> * update to survey questions (mdn#28) * codepen examples (mdn#27) Co-authored-by: Daryl Alexsy <[email protected]> * added deep dive code pens * fixed buttons * styled survey questions * lazy loading on codepen iframes * terms and privacy external links * Revert "terms and privacy external links" This reverts commit e4aa38e. Co-authored-by: Daryl Alexsy <[email protected]> Co-authored-by: Daryl Alexsy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can't argue with the results :)
First of all, we're not done with Travis. We'd want to run a linter across all apps (client, server, cli). We also want to run the
make deployment-buildwhich produces fully working.htmlwhich we should test that they work and can be opened withcurlor something.I'm not sure I'm doing the matrix stuff right. Would love some feedback here. There's a
before_installportion before the matrix but I think it runs that once per every step in the matix. I'd rather just do the stuff, currently inbefore_installonce BEFORE all the matrix sections.I'm happy to land this early and iterate. I just want to get the wheels rolling.
Also, if we dockerize everything all of these Travis DSL tricks will become moot.