-
Notifications
You must be signed in to change notification settings - Fork 508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dockerize? #23
Comments
Merged
I would strongly encourage using Docker for all of the reasons that @peterbe so nicely outlined. Two big thumbs up for dockerization from me! 👍 👍 😄 |
peterbe
added a commit
that referenced
this issue
May 24, 2021
* price blurb * upgrade landing page survey * remove 'Dev Reset survey' button because you just start in a new tab * change API URL and don't bother sending 'variant' as a query string Co-authored-by: Daryl Alexsy <[email protected]>
escattone
pushed a commit
that referenced
this issue
May 24, 2021
* added top banner * added layout * updated copy * price blurb (#22) * price blurb * new URL Co-authored-by: Daryl Alexsy <[email protected]> * fixed waitlist routing * font scaling * Upgrade landing page survey (#23) * price blurb * upgrade landing page survey * remove 'Dev Reset survey' button because you just start in a new tab * change API URL and don't bother sending 'variant' as a query string Co-authored-by: Daryl Alexsy <[email protected]> * update to survey questions (#28) * codepen examples (#27) Co-authored-by: Daryl Alexsy <[email protected]> * added deep dive code pens * fixed buttons * styled survey questions * lazy loading on codepen iframes * terms and privacy external links * Revert "terms and privacy external links" This reverts commit e4aa38e. Co-authored-by: Daryl Alexsy <[email protected]> Co-authored-by: Daryl Alexsy <[email protected]>
peterbe
added a commit
to peterbe/yari
that referenced
this issue
Jun 1, 2021
* added top banner * added layout * updated copy * price blurb (mdn#22) * price blurb * new URL Co-authored-by: Daryl Alexsy <[email protected]> * fixed waitlist routing * font scaling * Upgrade landing page survey (mdn#23) * price blurb * upgrade landing page survey * remove 'Dev Reset survey' button because you just start in a new tab * change API URL and don't bother sending 'variant' as a query string Co-authored-by: Daryl Alexsy <[email protected]> * update to survey questions (mdn#28) * codepen examples (mdn#27) Co-authored-by: Daryl Alexsy <[email protected]> * added deep dive code pens * fixed buttons * styled survey questions * lazy loading on codepen iframes * terms and privacy external links * Revert "terms and privacy external links" This reverts commit e4aa38e. Co-authored-by: Daryl Alexsy <[email protected]> Co-authored-by: Daryl Alexsy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
There are many advantages with using Docker.
Pros
In CI - Get out of however Travis does Node. This way the only determining input variable for what version of Node and yarn we get is the version string of node we specify in the
Dockerfile
. For example, as of today Travis preinstalls an ancient version ofyarn
and there's no roadmap to that updating.If we build a docker image, that contains ALL the rendered out .html files ready to be served, we can simply ship that docker container from Travis to Dockerhub and use something like Netlify to run that docker image.
For local development, every human developer would get the exact same version of Node and Yarn.
For local development, with a good docker-compose you would no longer need to "Open two terminals and in one run this and in another run that". Just
docker-compose up
and you get a complete dev environment.In CI, we would potentially have better control of caching. Instead of the cryptic Travis way of caching files.
Cons
Docker is slow. Sometimes makes it hard to do hacky, but necessary, debugging within installed
node_modules
.Not everyone is as comfortable with Docker as they are with pure Node and stuff. Possibly more applicable to contributors but on the flip-side being able to just say "To get started, run
docker-compose up
and you're off to the races".Too soon? We're not entirely sure where we're going with the outcome of this project so perhaps it's fine to leave it a bit "pure" and flat at the moment.
The text was updated successfully, but these errors were encountered: