Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: reflect Glean-derived nature of popularities.json #10609

Merged
merged 1 commit into from
Feb 28, 2024

Conversation

LeoMcA
Copy link
Member

@LeoMcA LeoMcA commented Feb 28, 2024

Summary

See also:

Problem

We didn't update the documentation around popularities when making the above changes, nor remove duped commands from the build.

Solution

Update the docs, remove the duped commands.


How did you test this change?

No testing done

also remove unnecessary command from build
@LeoMcA LeoMcA requested a review from a team as a code owner February 28, 2024 17:33
Copy link
Contributor

@caugner caugner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! 🙌

@LeoMcA LeoMcA changed the title chore(docs): reflect Glean-derived nature of popularities.json docs: reflect Glean-derived nature of popularities.json Feb 28, 2024
@LeoMcA LeoMcA enabled auto-merge (squash) February 28, 2024 17:45
@LeoMcA LeoMcA merged commit 02f2010 into main Feb 28, 2024
13 checks passed
@LeoMcA LeoMcA deleted the update-popularities-docs branch February 28, 2024 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants