remove checked in popularities.json #7551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterbe
requested review from
a team and
escattone
and removed request for
a team
escattone
approved these changes
Aug 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to mdn/yari#4286 the
popularities.jsonused to be checked in togit.Now, in Yari, it's downloaded from the AWS CloudFront's Athena logging, every single time. When we package
@mdn/yarito npmjs.com we put a copy of thepopularities.jsoninto:node_modules/@mdn/yari/popularities.jsonso when using theyarn startin mdn/content you always get the latest up-to-date version for your autocomplete search.