feat(macro/MDNSidebar): rewrite macro + add missing pages

[OnkarRuikar]

Add all the pages under https://github.com/mdn/content/tree/main/files/en-us/mdn to the macro.

All the documents under the dir hierarchy have been added. Sequence is as per mentions of the pages in coresponding overview pages.

mdnSidebar.mp4

Screenshots

Before change

After changes

[wbamberg]

This looks great! Did you consider using the design in https://github.com/mdn/yari/blob/main/kumascript/macros/LearnSidebar.ejs, which derives link text from page titles wherever possible, to avoid these huge string maps for l10n?

See also #8132.

[OnkarRuikar]

@wbamberg I've updated the macro to use titles. It does render well in local environment.

But don't know why the mdnsidebar.test.ts fails. May be because content repo is not checked out and .env is not set. So the code is not able find the page to get the titles. The learnSidebar.ts doesn't have test. Should I delete mdnsidebar.test.ts file?

[caugner]

Should I delete mdnsidebar.test.ts file?

FWIW I think it's okay to remove that test.

[OnkarRuikar]

Should I delete mdnsidebar.test.ts file?

FWIW I think it's okay to remove that test.

Done in bbafd23

Also removed from the content kitchensink page: mdn/content#31846

[wbamberg]

@caugner, please let me know if you're OK for me to review+merge this PR, or if you want to look.

[caugner]

@caugner, please let me know if you're OK for me to review+merge this PR, or if you want to look.

Let me run this by the content team, to be sure.

[OnkarRuikar]

I think we need to wait till mdn/content#31868 is fixed. We'll have to update the macro again after those changes are done.

[caugner]

I think we need to wait till mdn/content#31868 is fixed.

mdn/content#31878 fixed that meanwhile.

[OnkarRuikar]

@caugner I've updated this PR accordingly. We can merge this now.

[caugner]

@caugner I've updated this PR accordingly. We can merge this now.

@OnkarRuikar Thank you. Can you please add Before/After screenshots to the PR description? This will make it easier to have the change reviewed by the content team.

[OnkarRuikar]

@OnkarRuikar Thank you. Can you please add Before/After screenshots to the PR description? This will make it easier to have the change reviewed by the content team.

Done!

[caugner]

Had a quick chat with the content team, and all looks good, but can we change the order as follows: 🙏

• Community guidelines
• Writing guidelines
• PAB
• History

[OnkarRuikar]

Had a quick chat with the content team, and all looks good, but can we change the order as follows: 🙏

• Community guidelines
• Writing guidelines
• PAB
• History

This is how the new order looks: