Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tests): remove MDNSidebar from kitchensink #31846

Merged
merged 1 commit into from
Jan 22, 2024
Merged

fix(tests): remove MDNSidebar from kitchensink #31846

merged 1 commit into from
Jan 22, 2024

Conversation

OnkarRuikar
Copy link
Contributor

New {{MDNSidebar}} implementation requires mdn/content be checkedout in Yari workflows and tests. Better to remove the macro call from kitchensink.

@OnkarRuikar OnkarRuikar requested a review from a team as a code owner January 22, 2024 05:25
@OnkarRuikar OnkarRuikar requested review from hamishwillee and removed request for a team January 22, 2024 05:25
@github-actions github-actions bot added Content:Meta Content in the meta docs size/xs [PR only] 0-5 LoC changed labels Jan 22, 2024
@github-actions GitHub Actions
Copy link
Contributor

Preview URLs

External URLs (4)

URL: /en-US/docs/MDN/Kitchensink
Title: The MDN Content Kitchensink

@OnkarRuikar OnkarRuikar mentioned this pull request Jan 22, 2024
Merged
caugner
caugner approved these changes Jan 22, 2024
View reviewed changes
Copy link
Contributor

@caugner caugner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's okay to remove the sidebar from the kitchensink.

teoli2003
teoli2003 approved these changes Jan 22, 2024
View reviewed changes
Copy link
Contributor

@teoli2003 teoli2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

That was my understanding too; thank you @caugner !

@teoli2003 teoli2003 merged commit 13b7404 into mdn:main Jan 22, 2024
7 checks passed
@OnkarRuikar OnkarRuikar deleted the patch-3 branch January 22, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teoli2003 teoli2003 teoli2003 approved these changes

@caugner caugner caugner approved these changes

@hamishwillee hamishwillee Awaiting requested review from hamishwillee hamishwillee is a code owner automatically assigned from mdn/yari-content-mdn

Assignees
No one assigned
Labels
Content:Meta Content in the meta docs size/xs [PR only] 0-5 LoC changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@OnkarRuikar @caugner @teoli2003