Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[zh-CN] update 'column-rule-width' #18792

Merged
merged 4 commits into from
Mar 25, 2024
Merged

Conversation

T34-active
Copy link
Contributor

Description

update content in zh-CN

Motivation

zh-CN content does not match en-US content

Additional details

Related issues and pull requests

#18033
2a9498b

@T34-active T34-active requested a review from a team as a code owner March 20, 2024 09:36
@T34-active T34-active requested review from t7yang and removed request for a team March 20, 2024 09:36
@github-actions github-actions bot added the l10n-zh Issues related to Chinese content. label Mar 20, 2024
Copy link
Contributor

github-actions bot commented Mar 20, 2024

Preview URLs

Flaws (1)

URL: /zh-CN/docs/Web/CSS/column-rule-width
Title: column-rule-width
Flaw count: 1

  • translation_differences:
    • Differences in the important macros (5 in common of 7 possible)

(comment last updated: 2024-03-25 02:02:12)

@JasonLamv-t JasonLamv-t requested review from JasonLamv-t and removed request for t7yang March 24, 2024 07:30
Copy link
Member

@JasonLamv-t JasonLamv-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

一些建议

@@ -5,46 +5,82 @@ slug: Web/CSS/column-rule-width

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fill in the missing metadata about l10n.

files/zh-cn/web/css/column-rule-width/index.md Outdated Show resolved Hide resolved
files/zh-cn/web/css/column-rule-width/index.md Outdated Show resolved Hide resolved

```html
<p>
这是分成三列的文本。在 `column-rule-width` 属性中用于更改列与列之间的线条宽度。修改列之间线条的宽度。你不觉得这很棒吗?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[mdn-linter] reported by reviewdog 🐶

Suggested change
这是分成三列的文本。在 `column-rule-width` 属性中用于更改列与列之间的线条宽度。修改列之间线条的宽度。你不觉得这很棒吗?
这是分成三列的文本。在 `column-rule-width`
属性中用于更改列与列之间的线条宽度。修改列之间线条的宽度。你不觉得这很棒吗?

Copy link
Member

@JasonLamv-t JasonLamv-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! @T34-active

@JasonLamv-t JasonLamv-t merged commit 7ca2be9 into mdn:main Mar 25, 2024
7 checks passed
@T34-active T34-active deleted the column-rule-width branch March 26, 2024 03:10
ciyoe pushed a commit to ciyoe/translated-content that referenced this pull request Apr 20, 2024
* [zh-CN] update 'column-rule-width'

* Apply suggestions from code review

Co-authored-by: Jason Lam <[email protected]>

* add 110n

---------

Co-authored-by: Jason Lam <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
l10n-zh Issues related to Chinese content.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants