Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[zh-cn] unify {{CSSRef}} macro usage (remove unused parameter) #18033

Merged
merged 1 commit into from
Jan 24, 2024
Merged

[zh-cn] unify {{CSSRef}} macro usage (remove unused parameter) #18033

merged 1 commit into from
Jan 24, 2024

Conversation

leon-win
Copy link
Member

Description

This PR unifies {{CSSRef}} macro usage by removing unused parameter (https://github.com/mdn/yari/blob/main/kumascript/macros/CSSRef.ejs) for zh-cn locale.

Related issues and pull requests

Relates to mdn/content#31843

@leon-win leon-win requested a review from a team as a code owner January 24, 2024 20:06
@leon-win leon-win requested review from irvin and removed request for a team January 24, 2024 20:06
@github-actions github-actions bot added the l10n-zh Issues related to Chinese content. label Jan 24, 2024
@github-actions GitHub Actions
Copy link
Contributor

Preview URLs (20 pages)
Flaws (50)

Note! 2 documents with no flaws that don't need to be listed. 🎉

URL: /zh-CN/docs/Web/CSS/background
Title: background
Flaw count: 5

  • macros:
    • /zh-CN/docs/Web/CSS/-moz-background-size does not exist but fell back to /en-US/docs/Web/CSS/background-size
    • /zh-CN/docs/Web/CSS/-moz-background-inline-policy does not exist but fell back to /en-US/docs/Web/CSS/box-decoration-break
  • broken_links:
    • Can use the English (en-US) link as a fallback
    • Can use the English (en-US) link as a fallback
  • translation_differences:
    • Differences in the important macros (5 in common of 7 possible)

URL: /zh-CN/docs/Web/CSS/align-content
Title: align-content
Flaw count: 1

  • translation_differences:
    • Differences in the important macros (5 in common of 7 possible)

URL: /zh-CN/docs/Web/CSS/border-spacing
Title: border-spacing
Flaw count: 2

  • broken_links:
    • Can't resolve /samples/cssref/border-spacing.html
  • translation_differences:
    • Differences in the important macros (4 in common of 6 possible)

URL: /zh-CN/docs/Web/CSS/column-rule-style
Title: column-rule-style
Flaw count: 1

  • translation_differences:
    • Differences in the important macros (3 in common of 7 possible)

URL: /zh-CN/docs/Web/CSS/order
Title: order
Flaw count: 4

  • broken_links:
    • Can't resolve /zh-CN/docs/CSS
    • Can use the English (en-US) link as a fallback
    • Can use the English (en-US) link as a fallback
  • translation_differences:
    • Differences in the important macros (4 in common of 6 possible)

URL: /zh-CN/docs/Web/CSS/flex-direction
Title: flex-direction
Flaw count: 4

  • broken_links:
    • Can't resolve /zh-CN/docs/CSS
    • Can use the English (en-US) link as a fallback
    • Can use the English (en-US) link as a fallback
  • translation_differences:
    • Differences in the important macros (3 in common of 8 possible)

URL: /zh-CN/docs/Web/CSS/border-style
Title: border-style
Flaw count: 2

  • broken_links:
    • Can't resolve /zh-CN/docs/CSS
  • translation_differences:
    • Differences in the important macros (5 in common of 7 possible)

URL: /zh-CN/docs/Web/CSS/CSS_selectors
Title: CSS 选择器
Flaw count: 6

  • macros:
    • /zh-CN/docs/Web/HTML/Element/td does not exist but fell back to /en-US/docs/Web/HTML/Element/td
  • broken_links:
    • Can't resolve /zh-CN/docs/Web/CSS/Child_selectors
    • Can't resolve /zh-CN/docs/Web/CSS/General_sibling_selectors
    • Can't resolve /zh-CN/docs/Web/CSS/Adjacent_sibling_selectors
    • Anchor not lowercase
    • Anchor not lowercase

URL: /zh-CN/docs/Web/CSS/CSS_multicol_layout
Title: CSS 多列布局
Flaw count: 7

  • macros:
    • /zh-CN/docs/Web/CSS/column-fill does not exist but fell back to /en-US/docs/Web/CSS/column-fill
    • /zh-CN/docs/Web/CSS/column-width does not exist but fell back to /en-US/docs/Web/CSS/column-width
    • /zh-CN/docs/Web/CSS/break-before does not exist but fell back to /en-US/docs/Web/CSS/break-before
    • /zh-CN/docs/Web/CSS/orphans does not exist but fell back to /en-US/docs/Web/CSS/orphans
  • broken_links:
    • Can't resolve /zh-CN/docs/Web/CSS/CSS_multicol_layout/Spanning_Columns
    • Can't resolve /zh-CN/docs/Web/CSS/CSS_multicol_layout/Handling_content_breaks_in_multicol
  • translation_differences:
    • Differences in the important macros (2 in common of 4 possible)

URL: /zh-CN/docs/Web/CSS/border-top-right-radius
Title: border-top-right-radius
Flaw count: 3

  • macros:
    • /zh-CN/docs/Web/CSS/border-bottom-right-radius does not exist but fell back to /en-US/docs/Web/CSS/border-bottom-right-radius
  • broken_links:
    • Can't resolve /zh-CN/CSS/Shorthand_properties
  • translation_differences:
    • Differences in the important macros (4 in common of 9 possible)

URL: /zh-CN/docs/Web/CSS/Column_combinator
Title: Column combinator
Flaw count: 1

  • translation_differences:
    • Differences in the important macros (4 in common of 6 possible)

URL: /zh-CN/docs/Web/CSS/flex-flow
Title: flex-flow
Flaw count: 6

  • broken_links:
    • Can use the English (en-US) link as a fallback
    • Can't resolve /zh-CN/docs/CSS/Value_definition_syntax
    • Can use the English (en-US) link as a fallback
    • Can use the English (en-US) link as a fallback
    • Can use the English (en-US) link as a fallback
  • translation_differences:
    • Differences in the important macros (3 in common of 6 possible)

URL: /zh-CN/docs/Web/CSS/border-left-color
Title: border-left-color
Flaw count: 1

  • translation_differences:
    • Differences in the important macros (4 in common of 7 possible)

URL: /zh-CN/docs/Web/CSS/border-radius
Title: border-radius
Flaw count: 3

  • macros:
    • /zh-CN/docs/Web/CSS/border-bottom-right-radius does not exist but fell back to /en-US/docs/Web/CSS/border-bottom-right-radius
    • /zh-CN/docs/Web/CSS/border-bottom-right-radius does not exist but fell back to /en-US/docs/Web/CSS/border-bottom-right-radius
  • translation_differences:
    • Differences in the important macros (5 in common of 7 possible)

URL: /zh-CN/docs/Web/CSS/border-image-outset
Title: border-image-outset
Flaw count: 1

  • translation_differences:
    • Differences in the important macros (3 in common of 7 possible)

URL: /zh-CN/docs/Web/CSS/column-rule-width
Title: column-rule-width
Flaw count: 1

  • translation_differences:
    • Differences in the important macros (3 in common of 7 possible)

URL: /zh-CN/docs/Web/CSS/Next-sibling_combinator
Title: 接续兄弟组合器
Flaw count: 1

  • translation_differences:
    • Differences in the important macros (3 in common of 5 possible)

URL: /zh-CN/docs/Web/CSS/column-rule-color
Title: column-rule-color
Flaw count: 1

  • translation_differences:
    • Differences in the important macros (3 in common of 7 possible)

yin1999
yin1999 approved these changes Jan 24, 2024
View reviewed changes
Copy link
Member

@yin1999 yin1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @leon-win 🙏

@yin1999 yin1999 merged commit 2a9498b into mdn:main Jan 24, 2024
6 checks passed
@leon-win leon-win deleted the update/zh-cn-cssref-macro-usage branch January 24, 2024 23:32
@T34-active T34-active mentioned this pull request Mar 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yin1999 yin1999 yin1999 approved these changes

@irvin irvin Awaiting requested review from irvin irvin is a code owner automatically assigned from mdn/yari-content-zh

Assignees
No one assigned
Labels
l10n-zh Issues related to Chinese content.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leon-win @yin1999