top level await #10
Merged
top level await #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Hrm, I've tried testing this locally in both Fx and Chrone with the relevant flags enabled, and both browsers give me JSON errors related to the colors.json file:
- Chrome:
Uncaught SyntaxError: Unexpected token < in JSON at position 0 - Firefox:
JSON.parse: unexpected character at line 1 column 1 of the JSON data
Any thoughts?
|
I hadn't tested it as if it were running from the parent directory - sorry. It should work now |
chrisdavidmills
approved these changes
Jan 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a folder to modules with an example of using await within a module - extended from the previous examples