Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JS] Top-level await #297

Closed
chrisdavidmills opened this issue Dec 16, 2020 · 14 comments
Closed

[JS] Top-level await #297

chrisdavidmills opened this issue Dec 16, 2020 · 14 comments
Assignees
Labels
Content:JS JavaScript docs fx release archive A closed issue relating to firefox release notes for developers.

Comments

@chrisdavidmills
Copy link
Contributor

chrisdavidmills commented Dec 16, 2020

Acceptance criteria

    • The listed features are documented sufficiently on MDN
    • BCD is updated
    • Interactive example and data repos are updated if appropriate
    • The content has been reviewed as needed

Features to document

  1. Top-level await. There are a number of pages/resources that could do with being updated to cover this:

Related Gecko bugs

For folks helping with Firefox-related documentation features — make sure above AC have been done, but also:

  • Set bugs to dev-doc-complete
  • Add entry to Firefox release notes if feature is enabled in release
  • Add entry to Firefox experimental features page if feature is not yet enabled in release
@chrisdavidmills
Copy link
Contributor Author

@codehag You said you'd be interested in taking part in this one.

@Elchi3 This one sounds up your street too!

@jpmedley
Copy link
Collaborator

For what it's worth, I'm 99% certain this will ship in Chrome 89, which will reach beta the last week of January.

@chrisdavidmills
Copy link
Contributor Author

@jpmedley feel free to add a "Related Chromium bugs" section, if you think that'd help. I'd love to promote such practices.

@chrisdavidmills
Copy link
Contributor Author

@Rumyra pinging you on this one, to remind you about it. Consider this one highest priority for now.

@Elchi3 would you be willing and able to assist Ruth in scoping out the pages that need creating/updating for this one?

I also wondered if I could get @sideshowbarker and @jpmedley interested in helping to document this, depending on how much work we think is required here.

Thanks all.

@sideshowbarker
Copy link
Collaborator

I also wondered if I could get @sideshowbarker and @jpmedley interested in helping to document this, depending on how much work we think is required here.

I’d be very glad to put some time into it to help

@Rumyra Rumyra self-assigned this Jan 19, 2021
@Rumyra
Copy link
Collaborator

Rumyra commented Jan 19, 2021

Thanks peeps! I imagine the list above is pretty exhaustive, but I'm just going to go through and check.

I've been debating whether to split this up into separate issues, but I'll see what's involved - a check list might suffice 👍

@Rumyra
Copy link
Collaborator

Rumyra commented Jan 19, 2021

Here's a draft todo, in priority order:

(As top level await doesn't involved async I have only included modifications on these pages if necessary.)

Help needed:

From what I can tell it's been blocked in service workers until peeps make decisions w3c/ServiceWorker#1407 correct me if I'm wrong however.

@chrisdavidmills let me know what you think
@sideshowbarker is there anything particular you would like to do? I think if someone tackles a working example (and updates learning pages) someone else could tackle the copy amends on existing pages (I'm happy with either).

EDIT: I'm making a working example for testing, happy to add that to the repo

Release stuff:

  • I'm updating BCD now to reflect chrome flag - else it's fine
  • Add entry to experimental FF

@chrisdavidmills
Copy link
Contributor Author

LGTM, thanks @Rumyra !

@jpmedley
Copy link
Collaborator

I also wondered if I could get @sideshowbarker and @jpmedley interested in helping to document this, depending on how much work we think is required here.

I can help too.

@Rumyra
Copy link
Collaborator

Rumyra commented Jan 20, 2021

I've updated the above list and moved some amends to 'help needed' if either @sideshowbarker or @jpmedley would like to pick them up (thanks :) )

@Rumyra
Copy link
Collaborator

Rumyra commented Jan 24, 2021

@Rumyra
Copy link
Collaborator

Rumyra commented Feb 8, 2021

I believe all PRs are in for this now - should just need flag set to dev-doc-complete @chrisdavidmills 👍

@jpmedley
Copy link
Collaborator

jpmedley commented Feb 9, 2021

For what it's worth, I'm 99% certain this will ship in Chrome 89, which will reach beta the last week of January.

It made it into beta. Certainty for Chrome 89 now at 99.9%.

@chrisdavidmills
Copy link
Contributor Author

@Rumyra sorry for taking so long to check this out! This work looks amazing, thank you so much.

I've set the bug to DDC, and now we can close this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 10, 2022
@bsmth bsmth added fx release archive A closed issue relating to firefox release notes for developers. and removed Firefox 85 labels Dec 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Content:JS JavaScript docs fx release archive A closed issue relating to firefox release notes for developers.
Projects
None yet
Development

No branches or pull requests

5 participants