Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update border-image-slice value when fill is toggled (fixes #63) #175

Merged

Conversation

webcrawls
Copy link
Contributor

@webcrawls webcrawls commented Mar 25, 2024

Description:

This PR updates the Border Image Generator tool, fixing a bug where the CSS code output is not updated when the fill checkbox is toggled.

Motivation:

Before this PR, the "CSS Code" section of the tool would not update the border-image-slice property when the fill value is toggled. This can lead to an inconsistency between given inputs and the resulting outputs. This PR fixes that by calling setOutputCSS inside the setBorderFill function, bringing it in-line with the behaviour of the setBorderSlice function.

Additional details:

  • Can't think of any extra information, this PR is a single-line change so there shouldn't be many issues.

Related issues and pull requests:

@webcrawls webcrawls requested a review from a team as a code owner March 25, 2024 00:40
@webcrawls webcrawls requested review from pepelsbey and removed request for a team March 25, 2024 00:40
Copy link
Member

@pepelsbey pepelsbey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! Thank you :)

@pepelsbey pepelsbey merged commit 984cb14 into mdn:main May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants