Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Border-image generator] border-image-slice fill keyword not toggled in CSS output #63

Closed
Tracked by #180
strarsis opened this issue Jan 15, 2022 · 1 comment
Closed
Tracked by #180
Labels
bug Indicates an unexpected problem or unintended behavior. effort: medium Task is a medium effort. expert help needed This needs more information from a subject matter expert (SME). idle Issues and pull requests with no activity for three months. tool: border-image-generator

Comments

@strarsis
Copy link

Although the border-image-slice fill keyword is correctly toggled for the actual inline styles applied to the example element,
the CSS output (that can be viewed and copied by the user) is not. border-image-slice always contains the fill keyword,
regardless of the toggle state of the fill option.

@yarusome
Copy link
Contributor

The fill value in the output CSS code is updated after following steps:

  1. The "fill" option in the "border-image-slice" section is toggled;
  2. Any input slider or dropdown menu in this section is updated, or any config button in this section is clicked (not necessarily updating values in the config panel).

The script uses a lot of pre-ES6 tricks, which are beyond my knowledge to fix this issue.

@caugner caugner added needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. bug Indicates an unexpected problem or unintended behavior. expert help needed This needs more information from a subject matter expert (SME). effort: medium Task is a medium effort. and removed needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. labels Oct 10, 2023
@github-actions github-actions bot added the idle Issues and pull requests with no activity for three months. label Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Indicates an unexpected problem or unintended behavior. effort: medium Task is a medium effort. expert help needed This needs more information from a subject matter expert (SME). idle Issues and pull requests with no activity for three months. tool: border-image-generator
Projects
None yet
Development

No branches or pull requests

3 participants