Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put browser-compat in front-runner for xpath & xslt #5500

Merged

Conversation

teoli2003
Copy link
Contributor

@teoli2003 teoli2003 commented May 31, 2021

What was wrong/why is this fix needed? (quick summary only)

We want to have browser-compat in front-runner: this allows us to write {{Compat}} without parameter, and in the future, {{Spec}} (and likely more).

This PR covers xpath & xslt for the case without problem: 1 macro Compat in the page and its parameter matching the slug. Other cases (no Compat macros on a page, multiple Compat macros, macro not matching the slug, will be done at a later stage).

MDN URL of the main page changed

3 files in api/*

Issue number (if there is an associated issue)

openwebdocs/project#36

Anything else that could help us review it

@teoli2003 teoli2003 changed the title Put browser-compat in front-runner for xpath Put browser-compat in front-runner for xpath & xslt May 31, 2021
@github-actions
Copy link
Contributor

github-actions bot commented May 31, 2021

Preview URLs

Flaws

Note! 1 document with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/XSLT/Element/stylesheet
Title: <xsl:stylesheet>
on GitHub
Flaw count: 1

  • broken_links:
    • Can't resolve /en-US/docs/Web/XSLT/Element/for-each-group

URL: /en-US/docs/Web/XPath/Axes/child
Title: child
on GitHub
Flaw count: 1

  • bad_bcd_queries:
    • No BCD data for query: xpath.axes.child

External URLs

URL: /en-US/docs/Web/XSLT/Element/stylesheet
Title: <xsl:stylesheet>
on GitHub

No new external URLs


URL: /en-US/docs/Web/XPath/Axes/child
Title: child
on GitHub

No new external URLs


URL: /en-US/docs/Web/XPath/Axes/self
Title: self
on GitHub

No new external URLs

(this comment was updated 2021-05-31 08:32:56.904125)

@teoli2003 teoli2003 marked this pull request as ready for review May 31, 2021 08:32
@teoli2003 teoli2003 requested a review from a team as a code owner May 31, 2021 08:32
@teoli2003 teoli2003 requested review from Rumyra and removed request for a team May 31, 2021 08:32
Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm merging this for the moment but please note that BCD plans to remove XSLT and XPath data. (we don't have any real data, just stubs, and we don't want to maintain them anymore)

mdn/browser-compat-data#9830

@Elchi3 Elchi3 merged commit 0ee9ce9 into mdn:main May 31, 2021
@teoli2003 teoli2003 deleted the move-browser-compat-in-front-runner-xpath+xslt branch May 31, 2021 17:58
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants