Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove XPath and XSLT data #9830

Merged
merged 4 commits into from
Aug 17, 2021
Merged

Remove XPath and XSLT data #9830

merged 4 commits into from
Aug 17, 2021

Conversation

ddbeck
Copy link
Collaborator

@ddbeck ddbeck commented Apr 12, 2021 •
edited
Loading

cc: @Elchi3, @sideshowbarker

This PR is in draft status, until there's another set of breaking changes we can roll this up with.

This PR drops XPath and XSLT data, as well as associated schema, linting, docs, etc. This data is very incomplete. We're not foreclosing on this data returning at some point, but if it comes back, it needs to be in the context of an intentional effort.

Potentially affected MDN URLs
Fixes #9589 and fixes #9826 and fixes #2027.

@github-actions github-actions bot added data:xpath 🛤️ docs Issues or pull requests regarding the documentation of this project. infra Infrastructure issues (npm, GitHub Actions, releases) of this project linter Issues or pull requests regarding the tests / linter of the JSON files. schema Isses or pull requests regarding the JSON schema files used in this project. scripts Issues or pull requests regarding the scripts in scripts/. labels Apr 12, 2021
@ddbeck ddbeck mentioned this pull request Apr 12, 2021
Closed
@ddbeck ddbeck mentioned this pull request Apr 12, 2021
Closed
@bershanskiy bershanskiy mentioned this pull request Apr 16, 2021
Merged
5 tasks
@bershanskiy
Copy link
Contributor

Speaking of breaking changes, I remember there were a few incorrectly named features. Since feature renaming might break dependents, we might want to rename them all at once.

@ddbeck
Copy link
Collaborator Author

ddbeck commented Apr 16, 2021

@bershanskiy thanks for flagging that. I do record renames like that in the release notes (and add the needs-release-note label to applicable PRs). That said, we're not using all feature name-changes trigger a semver major release (we tried to document this at https://github.com/mdn/browser-compat-data#semantic-versioning-policy).

@queengooborg queengooborg mentioned this pull request May 10, 2021
Closed
11 tasks
@queengooborg
Copy link
Contributor

queengooborg commented May 11, 2021 •
edited
Loading

This PR should probably also close #2027 if/when it is merged, which is an issue to track the progress of migrating the remaining XSLT compat data.

@Elchi3 Elchi3 mentioned this pull request Jun 3, 2021
Merged
@queengooborg queengooborg added the needs content update This PR needs a corresponding update to mdn/content to update the documentation label Jun 16, 2021
@ddbeck ddbeck added this to the v4.0.0 milestone Aug 17, 2021
@ddbeck ddbeck force-pushed the xpath-xslt-removal branch from d88c330 to b243bfb Compare August 17, 2021 13:23
@ddbeck ddbeck mentioned this pull request Aug 17, 2021
Merged
@ddbeck ddbeck removed the needs content update This PR needs a corresponding update to mdn/content to update the documentation label Aug 17, 2021
@ddbeck ddbeck marked this pull request as ready for review August 17, 2021 13:40
@ddbeck ddbeck requested a review from Elchi3 August 17, 2021 13:40
Elchi3
Elchi3 approved these changes Aug 17, 2021
View reviewed changes
Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No more 🛤️ and 🚜 !!! 😄

@Elchi3 Elchi3 merged commit b10ea96 into mdn:main Aug 17, 2021
@Elchi3
Copy link
Member

Elchi3 commented Aug 17, 2021

(You should remove the 🛤️ and 🚜 labels from BCD)

@ddbeck ddbeck deleted the xpath-xslt-removal branch August 17, 2021 14:31
ddbeck added a commit to ddbeck/browser-compat-data that referenced this pull request Aug 17, 2021
@ddbeck
Add release note for mdn#9830
8e6f463
ddbeck added a commit that referenced this pull request Aug 19, 2021
@ddbeck
Prepare release v4.0.0 (#12036)
48aa0a9 
* Bump version to v4.0.0

* Add release note for #11234

* Bump known issues

* Add release note for #11760

* Add release note for #11286

* Add release note for #9830

* Add release note for #10334

* Add v4.0.0 highlights to release notes

* Add release note for #10753

* Revise description of `accepts_flags` hint

* Add release note for #11961

* Add release note for #12059

* Add stats
BertsLifee

This comment was marked as spam.

Sign in to view

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BertsLifee BertsLifee BertsLifee left review comments

@Elchi3 Elchi3 Elchi3 approved these changes

@sideshowbarker sideshowbarker sideshowbarker approved these changes

Assignees
No one assigned
Labels
docs Issues or pull requests regarding the documentation of this project. infra Infrastructure issues (npm, GitHub Actions, releases) of this project linter Issues or pull requests regarding the tests / linter of the JSON files. schema Isses or pull requests regarding the JSON schema files used in this project. scripts Issues or pull requests regarding the scripts in scripts/.
Projects
None yet
Milestone
v4.0.0
6 participants
@ddbeck @bershanskiy @queengooborg @Elchi3 @sideshowbarker @BertsLifee