Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix ECMAScript Versions #5342

Closed
wants to merge 1 commit into from
Closed

Conversation

Blakelist7
Copy link
Contributor

@Blakelist7 Blakelist7 commented May 26, 2021

Example 5, 6 in Document.cookie

Signed-off-by: Kanwal Singh [email protected]

What was wrong/why is this fix needed? (quick summary only)
Issue with ES2016, ES2015 Labels

MDN URL of the main page changed

Issue number (if there is an associated issue)
fixes: #4912

Anything else that could help us review it

@Blakelist7 Blakelist7 requested a review from a team as a code owner May 26, 2021 14:30
@Blakelist7 Blakelist7 requested review from wbamberg and removed request for a team May 26, 2021 14:30
@github-actions
Copy link
Contributor

github-actions bot commented May 26, 2021

Preview URLs

Flaws

URL: /en-US/docs/Web/API/Document/cookie
Title: Document.cookie
on GitHub
Flaw count: 5

  • macros:
    • /en-us/docs/web/api/parentnode (url: /en-US/docs/Web/API/ParentNode) does not exist
  • broken_links:
    • Is currently http:// but can become https://
    • Is currently http:// but can become https://
    • Can't resolve /en-US/docs/Web/API/URLUtils.pathname
    • Can't resolve /ja/docs/Web/HTTP

External URLs

URL: /en-US/docs/Web/API/Document/cookie
Title: Document.cookie
on GitHub

No new external URLs

(this comment was updated 2021-05-26 14:35:53.563071)

Example: 5, 6 in `Document.cookie`

Signed-off-by: Kanwal Singh <[email protected]>

fixes: mdn#4912
@wbamberg
Copy link
Collaborator

Thanks for the PR, @Blakelist7 , but in #5031 we're going to remove the two versions of this example, and just use modern JS.

@wbamberg wbamberg closed this May 26, 2021
@Blakelist7 Blakelist7 deleted the cookie branch May 26, 2021 19:17
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with "Document.cookie": In examples #5, #6 shouldn't it be "ES2015" instead of "ES2016" ?
2 participants