Issue with "Document.cookie": In examples #5, #6 shouldn't it be "ES2015" instead of "ES2016" ?

[ddziara]

MDN URL: https://developer.mozilla.org/en-US/docs/Web/API/Document/cookie

What information was incorrect, unhelpful, or incomplete?

Specific section or headline?

What did you expect to see?

Did you test this? If so, how?

MDN Content page report details

• Folder: en-us/web/api/document/cookie
• MDN URL: https://developer.mozilla.org/en-US/docs/Web/API/Document/cookie
• GitHub URL: https://github.com/mdn/content/blob/main/files/en-us/web/api/document/cookie/index.html
• Last commit: a177294
• Document last modified: 2021-04-09T17:25:26.000Z

[Blakelist7]

@ddziara I think we refer ES2016 as ES7, ES2015 as ES6 and ES5 for 2009 one
so you might be right. Let's ask @hamishwillee about it.

[hamishwillee]

MDN uses official names (so ES2015 for ES6, and ES2016 as ES7).

But the question was whether this should be "ES2015" instead of "ES2016".
Depends why you think it should be ES2015? If it is because of the use of arrow functions and startsWith then you'd be right.

However perhaps there is something else about this example which makes it ES2016. I don't think so but I'm not sufficiently expert to be sure. Which is why I didn't assign to me :-)

[Blakelist7]

Yeah I was assuming it to be "ES2015" because of arrow functions. I'll do some more research on it .
@peterbe could you take time to explain why is it ES2016 and not ES2015?
Thanks in advance

[peterbe]

Yeah I was assuming it to be "ES2015" because of arrow functions. I'll do some more research on it .
@peterbe could you take time to explain why is it ES2016 and not ES2015?
Thanks in advance

I can't speak to that. It's a content issue.

However, I see that there are flaws in the live samples in that it assumes that .find() always returns something.

[Blakelist7]

@ddziara Refer this https://www.codementor.io/@adroitcoder/includes-vs-indexof-in-javascript-ivxhatb3y

[Blakelist7]

Yeah I was assuming it to be "ES2015" because of arrow functions. I'll do some more research on it .
@peterbe could you take time to explain why is it ES2016 and not ES2015?
Thanks in advance

I can't speak to that. It's a content issue.

However, I see that there are flaws in the live samples in that it assumes that .find() always returns something.

As per my knowledge it returns undefined if no value satisfies the condition.

[hamishwillee]

So use of ES2016 is correct for example 6 because it uses includes, as @Blakelist7 refers to in #4912 (comment)

I wonder if to avoid this coming up again we should add a note? e.g. //ES2016 to //ES2016 (uses includes() introduced in ES2016)

example 5 might still be ES2015 - I don't see anything there introduced later.

[Blakelist7]

Thanks @hamishwillee for looking into the issue. Adding a note is a great idea.
Along side we could also correct example 5 .
Shall I create a PR ?

[Blakelist7]

@ddziara we can close this issue. As this example has been removed as per #5031.

[sideshowbarker]

Closing per #4912 (comment)