Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "=== Symbol("foo")" #33782

Merged
merged 1 commit into from
May 28, 2024
Merged

Revert "=== Symbol("foo")" #33782

merged 1 commit into from
May 28, 2024

Conversation

estelle
Copy link
Member

@estelle estelle commented May 27, 2024

I merged an error. this reverts it.

per: #33765 (comment)

fixes #33765

@estelle estelle requested a review from a team as a code owner May 27, 2024 22:38
@estelle estelle requested review from Josh-Cena and removed request for a team May 27, 2024 22:38
@github-actions github-actions bot added Content:JS JavaScript docs size/xs [PR only] 0-5 LoC changed labels May 27, 2024
@estelle estelle mentioned this pull request May 27, 2024
Merged
@github-actions GitHub Actions
Copy link
Contributor

Preview URLs

Josh-Cena
Josh-Cena approved these changes May 28, 2024
View reviewed changes
Copy link
Member

@Josh-Cena Josh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Josh-Cena Josh-Cena merged commit a0092ed into main May 28, 2024
8 checks passed
@Josh-Cena Josh-Cena deleted the estelle-patch-6 branch May 28, 2024 04:05
wbamberg added a commit to wbamberg/content that referenced this pull request May 28, 2024
@wbamberg
Merge remote-tracking branch 'upstream/main' into add-credential-types
76b6267 
* upstream/main: (55 commits)
  Replace `.` with `#` in example given selectors are `#ids` (mdn#33791)
  update info in cross browser testing strategies (mdn#33730)
  Clarify that `navigator.storage.persist()` depends on heuristics (mdn#33780)
  fix typo (mdn#33785)
  feat: improvements on Glossary/Hoisting (mdn#33787)
  CSS update: overview of shapes guide (mdn#33771)
  CSS update: Shapes from box values (mdn#33770)
  Fix issue 033506: correct droppedEntriesCount (mdn#33538)
  Revert "=== Symbol("foo")" (mdn#33782)
  docs(css): FF126 - Support for `shape()` function (mdn#33446)
  Bump lint-staged from 15.2.4 to 15.2.5 (mdn#33777)
  Bump ajv from 8.13.0 to 8.14.0 (mdn#33776)
  Add missing spaces for `subtlecrypto` (mdn#33774)
  fix: typo in `color_and_luminca` (mdn#33775)
  feat: improvments on gutters (mdn#33751)
  FF127Relnote- data: and javascript: URLS forbidden in base HREF (mdn#33738)
  update the content of SVG `<view>` element (mdn#33710)
  Clipboard.write() - log and fixes (mdn#33769)
  updated ClipboardItem and Clipboard documentation and examples using … (mdn#33262)
  Fix error in the code snippet for Symbol (mdn#33765)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Josh-Cena Josh-Cena Josh-Cena approved these changes

Assignees
No one assigned
Labels
Content:JS JavaScript docs size/xs [PR only] 0-5 LoC changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@estelle @Josh-Cena