Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update the content of SVG <view> element #33710

Merged
merged 7 commits into from
May 27, 2024

Conversation

T34-active
Copy link
Contributor

@T34-active T34-active commented May 22, 2024

Description

update this element introdution

image

MDN URL: https://developer.mozilla.org/en-US/docs/Web/SVG/Element/view

Motivation

Additional details

Related issues and pull requests

@T34-active T34-active requested a review from a team as a code owner May 22, 2024 06:12
@T34-active T34-active requested review from chrisdavidmills and removed request for a team May 22, 2024 06:12
@github-actions github-actions bot added Content:SVG SVG docs size/xs [PR only] 0-5 LoC changed labels May 22, 2024
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Copy link
Contributor

github-actions bot commented May 22, 2024

Preview URLs

(comment last updated: 2024-05-27 09:18:19)

Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the helpful update, @T34-active. I think what you've done is basically good; I just had a couple of language suggestions for you to make the use case of the element a bit more explicit in the intro.

files/en-us/web/svg/element/view/index.md Outdated Show resolved Hide resolved
Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks @T34-active! Let's get this merged.

@chrisdavidmills chrisdavidmills merged commit b439985 into mdn:main May 27, 2024
8 checks passed
@T34-active T34-active deleted the svg_view_20240522 branch May 27, 2024 09:37
wbamberg added a commit to wbamberg/content that referenced this pull request May 28, 2024
* upstream/main: (55 commits)
  Replace `.` with `#` in example given selectors are `#ids` (mdn#33791)
  update info in cross browser testing strategies (mdn#33730)
  Clarify that `navigator.storage.persist()` depends on heuristics (mdn#33780)
  fix typo (mdn#33785)
  feat: improvements on Glossary/Hoisting (mdn#33787)
  CSS update: overview of shapes guide (mdn#33771)
  CSS update: Shapes from box values (mdn#33770)
  Fix issue 033506: correct droppedEntriesCount (mdn#33538)
  Revert "=== Symbol("foo")" (mdn#33782)
  docs(css): FF126 - Support for `shape()` function (mdn#33446)
  Bump lint-staged from 15.2.4 to 15.2.5 (mdn#33777)
  Bump ajv from 8.13.0 to 8.14.0 (mdn#33776)
  Add missing spaces for `subtlecrypto` (mdn#33774)
  fix: typo in `color_and_luminca` (mdn#33775)
  feat: improvments on gutters (mdn#33751)
  FF127Relnote- data: and javascript: URLS forbidden in base HREF (mdn#33738)
  update the content of SVG `<view>` element (mdn#33710)
  Clipboard.write() - log and fixes (mdn#33769)
  updated ClipboardItem and Clipboard documentation and examples using … (mdn#33262)
  Fix error in the code snippet for Symbol (mdn#33765)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:SVG SVG docs size/xs [PR only] 0-5 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants