Update BCD keys for SVG attributes #32366

queengooborg · 2024-02-20T18:39:30Z

This PR performs a number of updates to the SVG attributes pages to clean up the pages:

Remove mention of global attributes on individual elements pages (Remove mention of global attributes on individual SVG elements pages #32383)
Remove landing pages for attribute categories (Remove landing pages for attribute categories #32477)
Update BCD keys (Only part remaining)

Note: review and merge along with mdn/browser-compat-data#22267.

Follow-up: remove all use of the SVGAttr macro.

See mdn/browser-compat-data#22267

github-actions · 2024-02-20T18:41:15Z

Preview URLs (78 pages)

Flaws (100)

URL: /en-US/docs/Web/SVG/Attribute/alignment-baseline
Title: alignment-baseline
Flaw count: 2

macros:
- /en-US/docs/Glossary/dominant_baseline does not exist
bad_bcd_queries:
- No BCD data for query: svg.global_attributes.alignment-baseline

URL: /en-US/docs/Web/SVG/Attribute/onclick
Title: onclick
Flaw count: 1

bad_bcd_queries:
- No BCD data for query: svg.global_attributes.onclick

URL: /en-US/docs/Web/SVG/Attribute/clip-rule
Title: clip-rule
Flaw count: 1

bad_bcd_queries:
- No BCD data for query: svg.global_attributes.clip-rule

URL: /en-US/docs/Web/SVG/Attribute/cursor
Title: cursor
Flaw count: 1

bad_bcd_queries:
- No BCD data for query: svg.global_attributes.cursor

URL: /en-US/docs/Web/SVG/Attribute/marker-mid
Title: marker-mid
Flaw count: 1

bad_bcd_queries:
- No BCD data for query: svg.global_attributes.marker-mid

URL: /en-US/docs/Web/SVG/Attribute/glyph-orientation-vertical
Title: glyph-orientation-vertical
Flaw count: 2

macros:
- /en-US/docs/Glossary/ideographic does not exist
bad_bcd_queries:
- No BCD data for query: svg.global_attributes.glyph-orientation-vertical

URL: /en-US/docs/Web/SVG/Attribute/requiredFeatures
Title: requiredFeatures
Flaw count: 2

broken_links:
- Can't resolve /en-US/docs/DOM/DOMImplementation.hasFeature
bad_bcd_queries:
- No BCD data for query: svg.global_attributes.requiredFeatures

URL: /en-US/docs/Web/SVG/Attribute/letter-spacing
Title: letter-spacing
Flaw count: 1

bad_bcd_queries:
- No BCD data for query: svg.global_attributes.letter-spacing

URL: /en-US/docs/Web/SVG/Attribute/stroke
Title: stroke
Flaw count: 1

bad_bcd_queries:
- No BCD data for query: svg.global_attributes.stroke

URL: /en-US/docs/Web/SVG/Attribute/stroke-linejoin
Title: stroke-linejoin
Flaw count: 1

bad_bcd_queries:
- No BCD data for query: svg.global_attributes.stroke-linejoin

URL: /en-US/docs/Web/SVG/Attribute/font-family
Title: font-family
Flaw count: 1

bad_bcd_queries:
- No BCD data for query: svg.global_attributes.font-family

URL: /en-US/docs/Web/SVG/Attribute/word-spacing
Title: word-spacing
Flaw count: 1

bad_bcd_queries:
- No BCD data for query: svg.global_attributes.word-spacing

URL: /en-US/docs/Web/SVG/Attribute/xlink:type
Title: xlink:type
Flaw count: 1

bad_bcd_queries:
- No BCD data for query: svg.global_attributes.xlink_type

URL: /en-US/docs/Web/SVG/Attribute/font-style
Title: font-style
Flaw count: 1

bad_bcd_queries:
- No BCD data for query: svg.global_attributes.font-style

URL: /en-US/docs/Web/SVG/Attribute/stop-color
Title: stop-color
Flaw count: 1

bad_bcd_queries:
- No BCD data for query: svg.global_attributes.stop-color

URL: /en-US/docs/Web/SVG/Attribute/clip
Title: clip
Flaw count: 1

bad_bcd_queries:
- No BCD data for query: svg.global_attributes.clip

URL: /en-US/docs/Web/SVG/Attribute/direction
Title: direction
Flaw count: 1

bad_bcd_queries:
- No BCD data for query: svg.global_attributes.direction

URL: /en-US/docs/Web/SVG/Attribute/kerning
Title: kerning
Flaw count: 1

bad_bcd_queries:
- No BCD data for query: svg.global_attributes.kerning

URL: /en-US/docs/Web/SVG/Attribute/color-interpolation-filters
Title: color-interpolation-filters
Flaw count: 2

macros:
- /en-US/docs/Glossary/sRGB does not exist
bad_bcd_queries:
- No BCD data for query: svg.global_attributes.color-interpolation-filters

URL: /en-US/docs/Web/SVG/Attribute/marker-end
Title: marker-end
Flaw count: 1

bad_bcd_queries:
- No BCD data for query: svg.global_attributes.marker-end

URL: /en-US/docs/Web/SVG/Attribute/class
Title: class
Flaw count: 1

bad_bcd_queries:
- No BCD data for query: svg.global_attributes.class

URL: /en-US/docs/Web/SVG/Attribute/color-profile
Title: color-profile
Flaw count: 1

bad_bcd_queries:
- No BCD data for query: svg.global_attributes.color-profile

URL: /en-US/docs/Web/SVG/Attribute/textLength
Title: textLength
Flaw count: 1

bad_bcd_queries:
- No BCD data for query: svg.global_attributes.textLength

URL: /en-US/docs/Web/SVG/Attribute/stroke-opacity
Title: stroke-opacity
Flaw count: 1

bad_bcd_queries:
- No BCD data for query: svg.global_attributes.stroke-opacity

URL: /en-US/docs/Web/SVG/Attribute/data-*
Title: data-*
Flaw count: 1

bad_bcd_queries:
- No BCD data for query: svg.global_attributes.data

URL: /en-US/docs/Web/SVG/Attribute/marker-start
Title: marker-start
Flaw count: 1

bad_bcd_queries:
- No BCD data for query: svg.global_attributes.marker-start

URL: /en-US/docs/Web/SVG/Attribute/fill-opacity
Title: fill-opacity
Flaw count: 1

bad_bcd_queries:
- No BCD data for query: svg.global_attributes.fill-opacity

URL: /en-US/docs/Web/SVG/Attribute/transform-origin
Title: transform-origin
Flaw count: 1

bad_bcd_queries:
- No BCD data for query: svg.global_attributes.transform-origin

URL: /en-US/docs/Web/SVG/Attribute/xlink:arcrole
Title: xlink:arcrole
Flaw count: 2

macros:
- /en-US/docs/Glossary/IRI does not exist
bad_bcd_queries:
- No BCD data for query: svg.global_attributes.xlink_arcrole

URL: /en-US/docs/Web/SVG/Attribute/clip-path
Title: clip-path
Flaw count: 1

bad_bcd_queries:
- No BCD data for query: svg.global_attributes.clip-path

URL: /en-US/docs/Web/SVG/Attribute/color
Title: color
Flaw count: 1

bad_bcd_queries:
- No BCD data for query: svg.global_attributes.color

URL: /en-US/docs/Web/SVG/Attribute/text-rendering
Title: text-rendering
Flaw count: 1

bad_bcd_queries:
- No BCD data for query: svg.global_attributes.text-rendering

URL: /en-US/docs/Web/SVG/Attribute/opacity
Title: opacity
Flaw count: 6

macros:
- /en-US/docs/Web/SVG/Element/audio does not exist
- /en-US/docs/Web/SVG/Element/canvas does not exist
- /en-US/docs/Web/SVG/Element/iframe does not exist
- /en-US/docs/Web/SVG/Element/unknown does not exist
- /en-US/docs/Web/SVG/Element/video does not exist
bad_bcd_queries:
- No BCD data for query: svg.global_attributes.opacity

URL: /en-US/docs/Web/SVG/Attribute/xml:lang
Title: xml:lang
Flaw count: 1

bad_bcd_queries:
- No BCD data for query: svg.global_attributes.xml_lang

URL: /en-US/docs/Web/SVG/Attribute/paint-order
Title: paint-order
Flaw count: 1

bad_bcd_queries:
- No BCD data for query: svg.global_attributes.paint-order

URL: /en-US/docs/Web/SVG/Attribute/text-anchor
Title: text-anchor
Flaw count: 1

bad_bcd_queries:
- No BCD data for query: svg.global_attributes.text-anchor

URL: /en-US/docs/Web/SVG/Attribute/stroke-linecap
Title: stroke-linecap
Flaw count: 1

bad_bcd_queries:
- No BCD data for query: svg.global_attributes.stroke-linecap

URL: /en-US/docs/Web/SVG/Attribute/visibility
Title: visibility
Flaw count: 5

macros:
- /en-US/docs/Web/SVG/Element/audio does not exist
- /en-US/docs/Web/SVG/Element/canvas does not exist
- /en-US/docs/Web/SVG/Element/iframe does not exist
- /en-US/docs/Web/SVG/Element/video does not exist
bad_bcd_queries:
- No BCD data for query: svg.global_attributes.visibility

URL: /en-US/docs/Web/SVG/Attribute/mask
Title: mask
Flaw count: 1

bad_bcd_queries:
- No BCD data for query: svg.global_attributes.mask

URL: /en-US/docs/Web/SVG/Attribute/id
Title: id
Flaw count: 1

bad_bcd_queries:
- No BCD data for query: svg.global_attributes.id

URL: /en-US/docs/Web/SVG/Attribute/xml:base
Title: xml:base
Flaw count: 2

macros:
- /en-US/docs/Glossary/IRI does not exist
bad_bcd_queries:
- No BCD data for query: svg.global_attributes.xml_base

URL: /en-US/docs/Web/SVG/Attribute/flood-color
Title: flood-color
Flaw count: 1

bad_bcd_queries:
- No BCD data for query: svg.global_attributes.flood-color

URL: /en-US/docs/Web/SVG/Attribute/pointer-events
Title: pointer-events
Flaw count: 1

bad_bcd_queries:
- No BCD data for query: svg.global_attributes.pointer-events

URL: /en-US/docs/Web/SVG/Attribute/dominant-baseline
Title: dominant-baseline
Flaw count: 1

bad_bcd_queries:
- No BCD data for query: svg.global_attributes.dominant-baseline

URL: /en-US/docs/Web/SVG/Attribute/font-stretch
Title: font-stretch
Flaw count: 1

bad_bcd_queries:
- No BCD data for query: svg.global_attributes.font-stretch

URL: /en-US/docs/Web/SVG/Attribute/image-rendering
Title: image-rendering
Flaw count: 1

bad_bcd_queries:
- No BCD data for query: svg.global_attributes.image-rendering

URL: /en-US/docs/Web/SVG/Attribute/fill
Title: fill
Flaw count: 1

bad_bcd_queries:
- No BCD data for query: svg.global_attributes.fill

URL: /en-US/docs/Web/SVG/Attribute/systemLanguage
Title: systemLanguage
Flaw count: 6

macros:
- /en-US/docs/Web/SVG/Element/audio does not exist
- /en-US/docs/Web/SVG/Element/canvas does not exist
- /en-US/docs/Web/SVG/Element/iframe does not exist
- /en-US/docs/Web/SVG/Element/unknown does not exist
- /en-US/docs/Web/SVG/Element/video does not exist
bad_bcd_queries:
- No BCD data for query: svg.global_attributes.systemLanguage

URL: /en-US/docs/Web/SVG/Attribute/style
Title: style
Flaw count: 1

bad_bcd_queries:
- No BCD data for query: svg.global_attributes.style

URL: /en-US/docs/Web/SVG/Attribute/font-weight
Title: font-weight
Flaw count: 1

bad_bcd_queries:
- No BCD data for query: svg.global_attributes.font-weight

URL: /en-US/docs/Web/SVG/Attribute/flood-opacity
Title: flood-opacity
Flaw count: 1

bad_bcd_queries:
- No BCD data for query: svg.global_attributes.flood-opacity

URL: /en-US/docs/Web/SVG/Attribute/xlink:title
Title: xlink:title
Flaw count: 1

bad_bcd_queries:
- No BCD data for query: svg.global_attributes.xlink_title

URL: /en-US/docs/Web/SVG/Attribute/stroke-width
Title: stroke-width
Flaw count: 1

bad_bcd_queries:
- No BCD data for query: svg.global_attributes.stroke-width

URL: /en-US/docs/Web/SVG/Attribute/lighting-color
Title: lighting-color
Flaw count: 1

bad_bcd_queries:
- No BCD data for query: svg.global_attributes.lighting-color

URL: /en-US/docs/Web/SVG/Attribute/filter
Title: filter
Flaw count: 1

bad_bcd_queries:
- No BCD data for query: svg.global_attributes.filter

URL: /en-US/docs/Web/SVG/Attribute/tabindex
Title: tabindex
Flaw count: 1

bad_bcd_queries:
- No BCD data for query: svg.global_attributes.tabindex

URL: /en-US/docs/Web/SVG/Attribute/stroke-miterlimit
Title: stroke-miterlimit
Flaw count: 1

bad_bcd_queries:
- No BCD data for query: svg.global_attributes.stroke-miterlimit

URL: /en-US/docs/Web/SVG/Attribute/font-size-adjust
Title: font-size-adjust
Flaw count: 1

bad_bcd_queries:
- No BCD data for query: svg.global_attributes.font-size-adjust

URL: /en-US/docs/Web/SVG/Attribute/enable-background
Title: enable-background
Flaw count: 1

bad_bcd_queries:
- No BCD data for query: svg.global_attributes.enable-background

URL: /en-US/docs/Web/SVG/Attribute/fill-rule
Title: fill-rule
Flaw count: 1

bad_bcd_queries:
- No BCD data for query: svg.global_attributes.fill-rule

URL: /en-US/docs/Web/SVG/Attribute/unicode-bidi
Title: unicode-bidi
Flaw count: 1

bad_bcd_queries:
- No BCD data for query: svg.global_attributes.unicode-bidi

URL: /en-US/docs/Web/SVG/Attribute/stroke-dasharray
Title: stroke-dasharray
Flaw count: 1

bad_bcd_queries:
- No BCD data for query: svg.global_attributes.stroke-dasharray

URL: /en-US/docs/Web/SVG/Attribute/lang
Title: lang
Flaw count: 1

bad_bcd_queries:
- No BCD data for query: svg.global_attributes.lang

URL: /en-US/docs/Web/SVG/Attribute/shape-rendering
Title: shape-rendering
Flaw count: 1

bad_bcd_queries:
- No BCD data for query: svg.global_attributes.shape-rendering

URL: /en-US/docs/Web/SVG/Attribute/stroke-dashoffset
Title: stroke-dashoffset
Flaw count: 1

bad_bcd_queries:
- No BCD data for query: svg.global_attributes.stroke-dashoffset

URL: /en-US/docs/Web/SVG/Attribute/color-interpolation
Title: color-interpolation
Flaw count: 1

bad_bcd_queries:
- No BCD data for query: svg.global_attributes.color-interpolation

URL: /en-US/docs/Web/SVG/Attribute/font-size
Title: font-size
Flaw count: 1

bad_bcd_queries:
- No BCD data for query: svg.global_attributes.font-size

URL: /en-US/docs/Web/SVG/Attribute/xml:space
Title: xml:space
Flaw count: 1

bad_bcd_queries:
- No BCD data for query: svg.global_attributes.xml_space

URL: /en-US/docs/Web/SVG/Attribute/font-variant
Title: font-variant
Flaw count: 1

bad_bcd_queries:
- No BCD data for query: svg.global_attributes.font-variant

URL: /en-US/docs/Web/SVG/Attribute/display
Title: display
Flaw count: 1

bad_bcd_queries:
- No BCD data for query: svg.global_attributes.display

URL: /en-US/docs/Web/SVG/Attribute/text-decoration
Title: text-decoration
Flaw count: 1

bad_bcd_queries:
- No BCD data for query: svg.global_attributes.text-decoration

URL: /en-US/docs/Web/SVG/Attribute/vector-effect
Title: vector-effect
Flaw count: 1

bad_bcd_queries:
- No BCD data for query: svg.global_attributes.vector-effect

URL: /en-US/docs/Web/SVG/Attribute/baseline-shift
Title: baseline-shift
Flaw count: 1

bad_bcd_queries:
- No BCD data for query: svg.global_attributes.baseline-shift

URL: /en-US/docs/Web/SVG/Attribute/writing-mode
Title: writing-mode
Flaw count: 1

bad_bcd_queries:
- No BCD data for query: svg.global_attributes.writing-mode

URL: /en-US/docs/Web/SVG/Attribute/href
Title: href
Flaw count: 2

macros:
- /en-US/docs/Glossary/SMIL does not exist
bad_bcd_queries:
- No BCD data for query: svg.global_attributes.href

URL: /en-US/docs/Web/SVG/Attribute/glyph-orientation-horizontal
Title: glyph-orientation-horizontal
Flaw count: 1

bad_bcd_queries:
- No BCD data for query: svg.global_attributes.glyph-orientation-horizontal

URL: /en-US/docs/Web/SVG/Attribute/overflow
Title: overflow
Flaw count: 2

macros:
- /en-US/docs/Web/SVG/Element/iframe does not exist
bad_bcd_queries:
- No BCD data for query: svg.global_attributes.overflow

URL: /en-US/docs/Web/SVG/Attribute/xlink:show
Title: xlink:show
Flaw count: 1

bad_bcd_queries:
- No BCD data for query: svg.global_attributes.xlink_show

(comment last updated: 2024-03-01 04:16:32)

chrisdavidmills

I'm not really able to check this all in detail, but the pages I've looked at LGTM; nice work @queengooborg.

queengooborg · 2024-02-21T16:33:16Z

Thank you, @chrisdavidmills!

Would you also be down to review/approve the BCD PR by chance?

chrisdavidmills · 2024-02-21T16:37:02Z

Thank you, @chrisdavidmills!

Would you also be down to review/approve the BCD PR by chance?

I am not, no. I can do, if no one grabs it.

files/en-us/web/svg/attribute/index.md

files/en-us/web/svg/element/a/index.md

files/en-us/web/svg/element/animate/index.md

estelle

I made a few comments. This PR is too big! Would it be possible to break it into 3:

the updating of browser compat in the front matter
removal of global attributes (while ensuring the links to those under "most notably" are included in their relevant pages
removal of the attribute category landing pages

I spot checked for #1, and think it's ok.
Changes are required for #2.
I did not look at category 3.

queengooborg · 2024-02-22T01:24:39Z

I can try splitting it into individual PRs, but I'm afraid there's a lot of crossover between the changes and they must be merged in order to prevent issues.

I'd probably recommend reviewing this PR per commit instead of all at once?

estelle · 2024-02-22T05:22:18Z

Review #1: assuming BCD was updated, there are no visible issues here.

estelle

Review part 2: Remove landing pages for attribute categories

A few minor issues in this section.

I'll review part 3 after the pages are updated to ensure the important attributes are not omitted from the element pages.

files/en-us/web/svg/attribute/d/index.md

files/en-us/web/svg/attribute/index.md

files/en-us/web/svg/attribute/presentation/index.md

queengooborg · 2024-03-01T04:17:21Z

This PR is now ready for re-review and merging, along with the BCD PR!

Changes were applied in other PRs

queengooborg · 2024-03-04T13:47:47Z

The BCD PR has been approved and merged, so this will be merged once the next BCD release is out!

queengooborg added 3 commits February 20, 2024 10:34

Remove mention of global attributes on individual elements pages

4fb2944

Remove landing pages for attribute categories

b125bf1

Update BCD keys

f62d4b7

See mdn/browser-compat-data#22267

queengooborg requested a review from a team February 20, 2024 18:39

queengooborg requested review from a team as code owners February 20, 2024 18:39

queengooborg requested review from Ryuno-Ki, estelle and chrisdavidmills and removed request for a team February 20, 2024 18:39

github-actions bot added Content:CSS Cascading Style Sheets docs Content:SVG SVG docs size/l [PR only] 501-1000 LoC changed labels Feb 20, 2024

chrisdavidmills approved these changes Feb 21, 2024

View reviewed changes

queengooborg mentioned this pull request Feb 21, 2024

Flatten svg.attributes into svg.global_attributes mdn/browser-compat-data#22267

Merged

estelle reviewed Feb 21, 2024

View reviewed changes

files/en-us/web/svg/attribute/index.md Outdated Show resolved Hide resolved

estelle reviewed Feb 22, 2024

View reviewed changes

files/en-us/web/svg/element/a/index.md Outdated Show resolved Hide resolved

estelle reviewed Feb 22, 2024

View reviewed changes

files/en-us/web/svg/element/animate/index.md Outdated Show resolved Hide resolved

estelle previously requested changes Feb 22, 2024

View reviewed changes

queengooborg mentioned this pull request Feb 22, 2024

Remove mention of global attributes on individual SVG elements pages #32383

Merged

estelle reviewed Feb 22, 2024

View reviewed changes

queengooborg marked this pull request as draft February 26, 2024 07:25

Merge branch 'main' into svg/attributes

0052850

queengooborg mentioned this pull request Feb 29, 2024

Remove landing pages for attribute categories #32477

Merged

Merge branch 'main' into svg/attributes

95937b0

github-actions bot added size/m [PR only] 51-500 LoC changed and removed Content:CSS Cascading Style Sheets docs size/l [PR only] 501-1000 LoC changed labels Mar 1, 2024

queengooborg marked this pull request as ready for review March 1, 2024 04:15

queengooborg changed the title ~~Clean up global SVG attributes~~ Update BCD keys for SVG attributes Mar 1, 2024

estelle approved these changes Mar 6, 2024

View reviewed changes

queengooborg merged commit cd840e7 into main Mar 6, 2024
10 checks passed

queengooborg deleted the svg/attributes branch March 6, 2024 14:40

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update BCD keys for SVG attributes #32366

Update BCD keys for SVG attributes #32366

queengooborg commented Feb 20, 2024 •

edited

Loading

github-actions bot commented Feb 20, 2024 •

edited

Loading

chrisdavidmills left a comment

queengooborg commented Feb 21, 2024

chrisdavidmills commented Feb 21, 2024

estelle left a comment

queengooborg commented Feb 22, 2024

estelle commented Feb 22, 2024

estelle left a comment

queengooborg commented Mar 1, 2024

queengooborg commented Mar 4, 2024

Update BCD keys for SVG attributes #32366

Update BCD keys for SVG attributes #32366

Conversation

queengooborg commented Feb 20, 2024 • edited Loading

github-actions bot commented Feb 20, 2024 • edited Loading

chrisdavidmills left a comment

Choose a reason for hiding this comment

queengooborg commented Feb 21, 2024

chrisdavidmills commented Feb 21, 2024

estelle left a comment

Choose a reason for hiding this comment

queengooborg commented Feb 22, 2024

estelle commented Feb 22, 2024

estelle left a comment

Choose a reason for hiding this comment

queengooborg commented Mar 1, 2024

queengooborg commented Mar 4, 2024

queengooborg commented Feb 20, 2024 •

edited

Loading

github-actions bot commented Feb 20, 2024 •

edited

Loading