Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flatten svg.attributes into svg.global_attributes #22267

Merged
merged 1 commit into from
Mar 4, 2024
Merged

Conversation

queengooborg
Copy link
Collaborator

@queengooborg queengooborg commented Feb 20, 2024

This PR flattens the svg.attributes category into svg.global_attributes to conform to the same structure as HTML/MathML.

Content PR: mdn/content#32366

Note: tests have been added to the mdn-bcd-collector and it already follows the structure introduced in this PR. Merging this PR will present a 0.71% coverage increase.

@queengooborg queengooborg added data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API needs content update 📝 This PR needs a corresponding update to mdn/content to update the documentation labels Feb 20, 2024
@github-actions github-actions bot added data:svg 🖌️ Compat data for SVG features. https://developer.mozilla.org/docs/Web/SVG and removed data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API labels Feb 20, 2024
queengooborg added a commit to mdn/content that referenced this pull request Feb 20, 2024
Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one comment:

I wonder if we shouldn't omit all the on* event attributes.

  • They don't suit the BCD data guidelines
  • The data we have for them is mostly null
  • The MDN pages don't use this data.

@queengooborg
Copy link
Collaborator Author

I'm down to remove the events, but I do see there's at least one page that does reference them (https://developer.mozilla.org/en-US/docs/Web/SVG/Attribute/onclick). Should we remove the events in a follow-up?

Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, let's do this in a follow-up. Approving but not merging so you can coordinate this with a BCD release. (and merge the content PR close to when the BCD release is picked up by Yari.)

@queengooborg queengooborg merged commit bda6d4b into main Mar 4, 2024
8 checks passed
@queengooborg queengooborg deleted the svg/attributes branch March 4, 2024 13:44
queengooborg added a commit to mdn/content that referenced this pull request Mar 6, 2024
* Remove mention of global attributes on individual elements pages

* Remove landing pages for attribute categories

* Update BCD keys

See mdn/browser-compat-data#22267
@queengooborg queengooborg removed the needs content update 📝 This PR needs a corresponding update to mdn/content to update the documentation label Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:svg 🖌️ Compat data for SVG features. https://developer.mozilla.org/docs/Web/SVG
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants