-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flatten svg.attributes into svg.global_attributes #22267
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just one comment:
I wonder if we shouldn't omit all the on* event attributes.
- They don't suit the BCD data guidelines
- The data we have for them is mostly
null
- The MDN pages don't use this data.
I'm down to remove the events, but I do see there's at least one page that does reference them (https://developer.mozilla.org/en-US/docs/Web/SVG/Attribute/onclick). Should we remove the events in a follow-up? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, let's do this in a follow-up. Approving but not merging so you can coordinate this with a BCD release. (and merge the content PR close to when the BCD release is picked up by Yari.)
* Remove mention of global attributes on individual elements pages * Remove landing pages for attribute categories * Update BCD keys See mdn/browser-compat-data#22267
This PR flattens the
svg.attributes
category intosvg.global_attributes
to conform to the same structure as HTML/MathML.Content PR: mdn/content#32366
Note: tests have been added to the mdn-bcd-collector and it already follows the structure introduced in this PR. Merging this PR will present a 0.71% coverage increase.