Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Path=/ requirement mentioning from Partitioned Cookies page #31472

Merged

Conversation

BartoszKlonowski
Copy link
Contributor

This pull request fixes #29001
It removes the mention of Path=/ requirement from the note in the Partitioned Cookies page.
This PR however leaves that parameter in place when it comes to example right above to keep all options mentioned.

There are no other requirements mentioned for Path=/ in that page.

@BartoszKlonowski BartoszKlonowski requested a review from a team as a code owner January 2, 2024 21:29
@BartoszKlonowski BartoszKlonowski requested review from dipikabh and removed request for a team January 2, 2024 21:29
@github-actions github-actions bot added the Content:Other Any docs not covered by another "Content:" label label Jan 2, 2024
Copy link
Contributor

github-actions bot commented Jan 2, 2024

Preview URLs

(comment last updated: 2024-01-05 00:10:57)

@dipikabh dipikabh self-assigned this Jan 4, 2024
Copy link
Contributor

@dipikabh dipikabh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @BartoszKlonowski, this change looks good 👍. Thank you!

The issue references another page where Path=/ can be removed: https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Set-Cookie#partitioned_cookie. Would it be possible to also include that change in this PR?

@BartoszKlonowski BartoszKlonowski requested a review from a team as a code owner January 5, 2024 00:09
@BartoszKlonowski BartoszKlonowski requested review from teoli2003 and removed request for a team January 5, 2024 00:09
@github-actions github-actions bot added the Content:HTTP HTTP docs label Jan 5, 2024
Copy link
Contributor

@dipikabh dipikabh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing the reported issue!

@dipikabh dipikabh merged commit 38ce7dd into mdn:main Jan 5, 2024
7 checks passed
estelle pushed a commit to estelle/content that referenced this pull request Jan 9, 2024
…dn#31472)

* Remove Path=/ requirement from partitioned cookies page

* Remove Path=/ requirement from set-cookie page
dipikabh pushed a commit to dipikabh/content that referenced this pull request Jan 17, 2024
…dn#31472)

* Remove Path=/ requirement from partitioned cookies page

* Remove Path=/ requirement from set-cookie page
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:HTTP HTTP docs Content:Other Any docs not covered by another "Content:" label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CHIPS no longer requires Path=/
2 participants