Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update implicit ARIA roles according to spec changes #29546

Merged
merged 6 commits into from
Oct 14, 2023
Merged

Update implicit ARIA roles according to spec changes #29546

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
5ae6a08
Set implicit role mappings to `generic`
krkk Oct 8, 2023
a272a8b
Set address' element implicit role to `group`
krkk Oct 8, 2023
f294dc9
Assign ARIA 1.2 roles to elements
krkk Oct 8, 2023
151b798
Make `<section>` with inaccessible name's implicit role to be `generic`
krkk Oct 8, 2023
4e6d28f
Set implicit ARIA mapping for <s> element to `deletion`
krkk Oct 8, 2023
2512fa4
Set `form` as the only implicit ARIA role for the form element
krkk Oct 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions files/en-us/web/html/element/form/index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,9 +157,7 @@ The following attributes control behavior during form submission.
<tr>
<th scope="row">Implicit ARIA role</th>
<td>
<code><a href="/en-US/docs/Web/Accessibility/ARIA/Roles/form_role">form</a></code> if the form has an
<a href="https://www.w3.org/TR/accname-1.1/#dfn-accessible-name">accessible name</a>, otherwise
<a href="https://www.w3.org/TR/html-aria/#dfn-no-corresponding-role">no corresponding role</a>
<code><a href="/en-US/docs/Web/Accessibility/ARIA/Roles/form_role">form</a></code>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While this condition got removed in the spec, there's now a note saying quite the same thing in the cell next to it.
Removed it anyway for the sake of completeness, but I'd like someone to verify if it's alright or what should be done instead.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added #29636 to address this.

</td>
</tr>
<tr>
Expand Down