Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARIA form role: exposed if it has an accessible name #29636

Closed
wants to merge 1 commit into from

Conversation

estelle
Copy link
Member

@estelle estelle commented Oct 14, 2023

@estelle estelle requested a review from a team as a code owner October 14, 2023 00:21
@estelle estelle requested review from chrisdavidmills and removed request for a team October 14, 2023 00:21
@github-actions github-actions bot added the Content:HTML Hypertext Markup Language docs label Oct 14, 2023
@github-actions
Copy link
Contributor

Preview URLs

Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@estelle hrm, I feel like I've made a mountain out of a molehill with this one. Let me know what you think!

@@ -7,7 +7,7 @@ browser-compat: html.elements.form

{{HTMLSidebar}}

The **`<form>`** [HTML](/en-US/docs/Web/HTML) element represents a document section containing interactive controls for submitting information.
The **`<form>`** [HTML](/en-US/docs/Web/HTML) element represents a document section containing interactive controls for submitting information. The form is not exposed as a landmark region unless it has an [accessible name](/en-US/docs/Glossary/Accessible_name).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks correct to me, but I can't help wondering whether the average reader will have a clue what a landmark region is. Would it be even better to link to something that explains what it is and how to give it an accessible name, and/or provide more clues in the text, for example, something like

The form is not exposed to screen readers as a landmark region unless it has an accessible name provided via the name attribute.

?

Also, does a form always need a specific accessible name, or is this only needed in some circumstances, e.g. when you have multiple forms on a page? If there is only one form and the top-level heading for the pages clearly says this page contains a form, isn't it OK to not include this as long as the individual form elements are clearly labelled?

I feel like I'm being horribly picky now, but it seems to me like this statement needs to come with some advice on when this is necessary. And, if it is necessary to always include this, examples on the page and elsewhere need to be updated to align with this advice.

@estelle estelle closed this Oct 16, 2023
@estelle
Copy link
Member Author

estelle commented Oct 16, 2023

Thanks for the review. This PR was a mistake. I meant to add the sentence to the form role not form element.
closed this and opened:
#29665

@chrisdavidmills
Copy link
Contributor

Thanks for the review. This PR was a mistake. I meant to add the sentence to the form role not form element. closed this and opened: #29665

Ah, that makes more sense ;-)

@chrisdavidmills chrisdavidmills deleted the estelle-patch-1 branch October 17, 2023 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:HTML Hypertext Markup Language docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants