Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run prettier on .md files in precommit hook #27936

Merged
merged 1 commit into from
Jul 14, 2023

Conversation

OnkarRuikar
Copy link
Contributor

@OnkarRuikar OnkarRuikar commented Jul 14, 2023

Now we won't have to manually run prettier on .md files!

Tested the PR by running: prettier --ignore-unknown -w * command on the repo.

Note: If you do not want any file to be formatted by Prettier then add the exception to the .prettierignore file.

@OnkarRuikar OnkarRuikar requested a review from a team as a code owner July 14, 2023 03:37
Copy link
Collaborator

@queengooborg queengooborg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that all files are formatted with Prettier, this is LGTM!

@queengooborg queengooborg merged commit 5600008 into mdn:main Jul 14, 2023
@OnkarRuikar OnkarRuikar deleted the update_husky branch July 14, 2023 04:45
LeoMcA added a commit that referenced this pull request Aug 2, 2023
)

followed the markdownlint/prettier ordering defined in the package.json
fix:md and lint:md commands

also update `markdownlint-cli2-fix` command to `markdownlint-cli2 --fix`

see: https://github.com/okonet/lint-staged#task-concurrency

follow-up to: #27936

---------

Co-authored-by: Onkar Ruikar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants