Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Format /mozilla using Prettier #24050

Merged
merged 1 commit into from
Jul 14, 2023
Merged

Format /mozilla using Prettier #24050

merged 1 commit into from
Jul 14, 2023

Conversation

queengooborg
Copy link
Collaborator

@queengooborg queengooborg commented Feb 1, 2023 •
edited
Loading

This PR is a part of a project to format all of the documents using Prettier, and then enforce Prettier formatting for the files going forward. This PR formats the /mozilla folder.

Note: all of the remaining changes are simply adding trailing commas now; the documentation is otherwise formatted!

@queengooborg queengooborg requested review from a team as code owners February 1, 2023 09:47
@queengooborg queengooborg requested review from bsmth and rebloor and removed request for a team February 1, 2023 09:47
@github-actions github-actions bot added Content:Other Any docs not covered by another "Content:" label Content:WebExt WebExtensions docs labels Feb 1, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Feb 1, 2023 •
edited
Loading

Preview URLs (46 pages)

(comment last updated: 2023-07-13 01:02:25)

@github-actions
Copy link
Contributor

github-actions bot commented Feb 1, 2023

This pull request has merge conflicts that must be resolved before it can be merged.

@queengooborg queengooborg requested a review from a team as a code owner February 1, 2023 10:58
bsmth
bsmth reviewed Feb 1, 2023
View reviewed changes
files/en-us/mozilla/add-ons/webextensions/api/sidebaraction/seticon/index.md Outdated
16: "path/to/image16.jpg",
32: "path/to/image32.jpg"
}
"16": "path/to/image16.jpg",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here as above

@bsmth
Copy link
Member

bsmth commented Feb 1, 2023 •
edited
Loading

Thanks @queengooborg.

Some notes:

TODO:
I can take care of this on this branch later:

  • json blocks should be changed to js where appropriate

see #24050 (comment)

@github-actions
Copy link
Contributor

github-actions bot commented Feb 1, 2023

This pull request has merge conflicts that must be resolved before it can be merged.

@Josh-Cena
Copy link
Member

We're in this place again... See #21175

@bsmth
Copy link
Member

bsmth commented Feb 1, 2023

Thanks for flagging @Josh-Cena. @queengooborg maybe best to skip files/en-us/mozilla/* for now.

@queengooborg queengooborg mentioned this pull request Feb 1, 2023
Closed
73 tasks
@queengooborg
Copy link
Collaborator Author

I don't feel as though we should skip over formatting any folder of documents if we can avoid it. If I may be blunt, I don't think that linting is the web extensions team's call to make, and if MDN is deciding to proceed with using Prettier everywhere, they should adhere to the decisions made higher up.

I reached out to Schalk regarding this. For now, let's leave this PR open.

@queengooborg queengooborg marked this pull request as draft February 2, 2023 12:13
@github-actions
Copy link
Contributor

github-actions bot commented Feb 7, 2023

This pull request has merge conflicts that must be resolved before it can be merged.

@github-actions github-actions bot added the merge conflicts 🚧 [PR only] label Jun 13, 2023
@github-actions
Copy link
Contributor

This pull request has merge conflicts that must be resolved before it can be merged.

@github-actions github-actions bot removed the merge conflicts 🚧 [PR only] label Jun 13, 2023
@queengooborg
Copy link
Collaborator Author

This is now the last folder that needs to be formatted; all other folders have been formatted!

@queengooborg queengooborg marked this pull request as ready for review June 17, 2023 09:50
@github-actions github-actions bot removed the Content:Other Any docs not covered by another "Content:" label label Jul 7, 2023
@queengooborg queengooborg marked this pull request as draft July 8, 2023 11:47
@queengooborg
Copy link
Collaborator Author

I've gone ahead and marked this PR as a draft for the time being. This PR will act as the overview PR, and individual changes will be (have been) cherry-picked into other non-Prettier-specific PRs that should be much easier to review and merge and consider good to go.

@github-actions github-actions bot added the merge conflicts 🚧 [PR only] label Jul 9, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 9, 2023

This pull request has merge conflicts that must be resolved before it can be merged.

@github-actions github-actions bot added merge conflicts 🚧 [PR only] and removed merge conflicts 🚧 [PR only] labels Jul 10, 2023
@github-actions
Copy link
Contributor

This pull request has merge conflicts that must be resolved before it can be merged.

@github-actions github-actions bot added merge conflicts 🚧 [PR only] and removed merge conflicts 🚧 [PR only] labels Jul 11, 2023
@github-actions
Copy link
Contributor

This pull request has merge conflicts that must be resolved before it can be merged.

@github-actions github-actions bot added merge conflicts 🚧 [PR only] and removed merge conflicts 🚧 [PR only] labels Jul 11, 2023
@github-actions
Copy link
Contributor

This pull request has merge conflicts that must be resolved before it can be merged.

@github-actions github-actions bot added merge conflicts 🚧 [PR only] and removed merge conflicts 🚧 [PR only] labels Jul 11, 2023
@github-actions
Copy link
Contributor

This pull request has merge conflicts that must be resolved before it can be merged.

@github-actions github-actions bot removed the merge conflicts 🚧 [PR only] label Jul 13, 2023
@queengooborg queengooborg marked this pull request as ready for review July 13, 2023 01:01
@queengooborg
Copy link
Collaborator Author

Alright, all other changes have been merged, so all that's left is to add trailing commas in various locations and we're good to go!

dipikabh
dipikabh approved these changes Jul 14, 2023
View reviewed changes
Copy link
Contributor

@dipikabh dipikabh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @queengooborg! 🙌

@dipikabh dipikabh merged commit 03d9b93 into mdn:main Jul 14, 2023
@queengooborg queengooborg deleted the prettier/mozilla branch July 14, 2023 01:08
@OnkarRuikar OnkarRuikar mentioned this pull request Jul 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsmth bsmth bsmth left review comments

@dipikabh dipikabh dipikabh approved these changes

@rebloor rebloor Awaiting requested review from rebloor rebloor is a code owner automatically assigned from mdn/yari-content-mozilla-add-ons

Assignees
No one assigned
Labels
Content:WebExt WebExtensions docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@queengooborg @bsmth @Josh-Cena @dipikabh