Add crlf check to the markdownlint PR check workflow
#26664
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview URLs (comment last updated: 2023-05-20 00:22:55) |
OnkarRuikar
force-pushed
the
line_endings
branch
2 times, most recently
from
0758bd1 to
3605b9f
Compare
github-actions
bot
added
Content:CSS
OnkarRuikar
force-pushed
the
line_endings
branch
4 times, most recently
from
d5ced04 to
0cedf24
Compare
|
Closing this as couldn't reproduce the issue in content workflows where a file with As per current setup people can accidentally commit files with CRLF. And those who(including workflows) checkout the code have to make sure they are using auto LF settings to get the corrected version, and when they commit the file it gets fixed in the repo. So forcing If we really need this then let me know. There are various approaches and places to implement this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #26609 (comment)
To avoid files with
crlfline endings in the repo this adds a check in PR check workflow.