-
Notifications
You must be signed in to change notification settings - Fork 22.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Synchronize with BCD v5.2.56 #26609
Synchronize with BCD v5.2.56 #26609
Conversation
Preview URLs Flaws (1)Note! 1 document with no flaws that don't need to be listed. 🎉 URL:
(comment last updated: 2023-05-06 01:10:54) |
status: | ||
- experimental |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we generating SeeCompatTable
banners now, a la mdn/yari#7227? If not why doesn't this PR add the macro call? Sorry if I'm being slow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not the fault of the script the first commit by @CanadaHonk introduced crlf
endings to the lines:
fsh$ git ls-files --eol | grep "w/crlf"
i/crlf w/crlf attr/text=auto eol=lf files/en-us/web/api/cssimportrule/supportstext/index.md
So something went wrong with the regexes in the script. Please do these git line ending settings in your local.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies, editor defaults 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wondering if we can detect these and fix them with Husky (or at least in CI)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wondering if we can detect these and fix them with Husky (or at least in CI)
This will be fixed by Prettier. If we really so desire, a markdownlint replacement should do as well.
BCD release v5.2.56
/cc @queengooborg @sideshowbarker