Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synchronize with BCD v5.2.56 #26609

Merged
merged 2 commits into from
May 6, 2023
Merged

Synchronize with BCD v5.2.56 #26609

merged 2 commits into from
May 6, 2023

Conversation

OnkarRuikar
Copy link
Contributor

@OnkarRuikar OnkarRuikar requested a review from a team as a code owner May 6, 2023 00:31
@OnkarRuikar OnkarRuikar requested review from wbamberg and removed request for a team May 6, 2023 00:31
@github-actions github-actions bot added the Content:WebAPI Web API docs label May 6, 2023
@github-actions
Copy link
Contributor

github-actions bot commented May 6, 2023

Preview URLs

Flaws (1)

Note! 1 document with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/API/CSSImportRule/supportsText
Title: CSSImportRule: supportsText property
Flaw count: 1

  • bad_bcd_queries:
    • No BCD data for query: api.CSSImportRule.supportsText

(comment last updated: 2023-05-06 01:10:54)

@sideshowbarker sideshowbarker merged commit 17900b2 into mdn:main May 6, 2023
Comment on lines +6 to +7
status:
- experimental
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we generating SeeCompatTable banners now, a la mdn/yari#7227? If not why doesn't this PR add the macro call? Sorry if I'm being slow.

Copy link
Contributor Author

@OnkarRuikar OnkarRuikar May 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not the fault of the script the first commit by @CanadaHonk introduced crlf endings to the lines:

fsh$ git ls-files --eol | grep "w/crlf"
i/crlf  w/crlf  attr/text=auto eol=lf   files/en-us/web/api/cssimportrule/supportstext/index.md

So something went wrong with the regexes in the script. Please do these git line ending settings in your local.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies, editor defaults 😅

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies, editor defaults sweat_smile

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wondering if we can detect these and fix them with Husky (or at least in CI)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wondering if we can detect these and fix them with Husky (or at least in CI)

This will be fixed by Prettier. If we really so desire, a markdownlint replacement should do as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:WebAPI Web API docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants