-
Notifications
You must be signed in to change notification settings - Fork 22.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding at() docs #1216
Adding at() docs #1216
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nits
files/en-us/web/javascript/reference/global_objects/array/at/index.html
Outdated
Show resolved
Hide resolved
files/en-us/web/javascript/reference/global_objects/string/at/index.html
Outdated
Show resolved
Hide resolved
…ndex.html Co-authored-by: Michael[tm] Smith <[email protected]>
…index.html Co-authored-by: Michael[tm] Smith <[email protected]>
Hi @Rumyra ! I'm just preparing for the Fx 85 launch and giving this a review as part of it. Looks mostly good. Any nitpicks I find I'll make directly to the text and not both you with them. A few points to help you with the remainder:
Can you make this a priority? The launch of Fx 85 is in 8 days. Thanks! |
I've updated the spec links and bcd... one thing is the at method is not in the draft spec yet 😬 I've added what should be the link... |
Hrm, this makes me wonder whether we shouldn't just link to the draft proposal instead for now. @Elchi3 , what would you do here? |
Let me know - I'll update here if it needs changing 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great! Happy to see you contributing to JS ref docs. I've reviewed this some more and left comments on the Array.prototype.at page for you, but they also apply to the other two methods mostly.
files/en-us/web/javascript/reference/global_objects/array/at/index.html
Outdated
Show resolved
Hide resolved
files/en-us/web/javascript/reference/global_objects/array/at/index.html
Outdated
Show resolved
Hide resolved
files/en-us/web/javascript/reference/global_objects/array/at/index.html
Outdated
Show resolved
Hide resolved
files/en-us/web/javascript/reference/global_objects/array/at/index.html
Outdated
Show resolved
Hide resolved
files/en-us/web/javascript/reference/global_objects/array/at/index.html
Outdated
Show resolved
Hide resolved
…ndex.html Co-authored-by: Florian Scholz <[email protected]>
…ndex.html Co-authored-by: Florian Scholz <[email protected]>
Converting to draft until I've done feedbacks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great stuff! Some nits and I think we're good to go.
files/en-us/web/javascript/reference/global_objects/array/at/index.html
Outdated
Show resolved
Hide resolved
files/en-us/web/javascript/reference/global_objects/array/at/index.html
Outdated
Show resolved
Hide resolved
files/en-us/web/javascript/reference/global_objects/string/at/index.html
Outdated
Show resolved
Hide resolved
files/en-us/web/javascript/reference/global_objects/string/at/index.html
Outdated
Show resolved
Hide resolved
files/en-us/web/javascript/reference/global_objects/string/at/index.html
Show resolved
Hide resolved
files/en-us/web/javascript/reference/global_objects/typedarray/at/index.html
Outdated
Show resolved
Hide resolved
files/en-us/web/javascript/reference/global_objects/typedarray/at/index.html
Outdated
Show resolved
Hide resolved
files/en-us/web/javascript/reference/global_objects/typedarray/at/index.html
Outdated
Show resolved
Hide resolved
…ndex.html Co-authored-by: Florian Scholz <[email protected]>
…index.html Co-authored-by: Florian Scholz <[email protected]>
…index.html Co-authored-by: Florian Scholz <[email protected]>
…/at/index.html Co-authored-by: Florian Scholz <[email protected]>
…/at/index.html Co-authored-by: Florian Scholz <[email protected]>
…ndex.html Co-authored-by: Florian Scholz <[email protected]>
…/at/index.html Co-authored-by: Florian Scholz <[email protected]>
Adding array.at(), string.at() and typedarray.at() pages.
Looking at a review as these are actually my first js ref docs... some notes:
tl:dr; please review but don't merge until I've resolved above :) @chrisdavidmills